Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable in-chart "Explore underlying data" by default #74332

Merged
merged 3 commits into from
Aug 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/drilldowns/explore-underlying-data.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ applies the filters and time range created by the events that triggered the acti
[role="screenshot"]
image::images/explore_data_in_chart.png[Explore underlying data from chart]

You can disable this action by adding the following line to your `kibana.yml` config.
To enable this action add the following line to your `kibana.yml` config.

["source","yml"]
-----------
xpack.discoverEnhanced.actions.exploreDataInChart.enabled: false
xpack.discoverEnhanced.actions.exploreDataInChart.enabled: true
-----------
2 changes: 1 addition & 1 deletion x-pack/plugins/discover_enhanced/server/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { PluginConfigDescriptor } from '../../../../src/core/server';
export const configSchema = schema.object({
actions: schema.object({
exploreDataInChart: schema.object({
enabled: schema.boolean({ defaultValue: true }),
enabled: schema.boolean({ defaultValue: false }),
}),
}),
});
Expand Down
5 changes: 4 additions & 1 deletion x-pack/test/functional/apps/dashboard/drilldowns/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ export default function ({ loadTestFile, getService }: FtrProviderContext) {

loadTestFile(require.resolve('./dashboard_drilldowns'));
loadTestFile(require.resolve('./explore_data_panel_action'));
loadTestFile(require.resolve('./explore_data_chart_action'));

// Disabled for now as it requires xpack.discoverEnhanced.actions.exploreDataInChart.enabled
// setting set in kibana.yml to work. Once that is enabled by default, we can re-enable this test suite.
// loadTestFile(require.resolve('./explore_data_chart_action'));
});
}