Actions add proxy support #74289
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -269,6 +269,7 @@ describe('execute()', () => { | |
| "message": "a message to you", | ||
| "subject": "the subject", | ||
| }, | ||
| "proxySettings": undefined, | ||
| "routing": Object { | ||
| "bcc": Array [ | ||
| "[email protected]", | ||
|
|
@@ -326,6 +327,7 @@ describe('execute()', () => { | |
| "message": "a message to you", | ||
| "subject": "the subject", | ||
| }, | ||
| "proxySettings": undefined, | ||
| "routing": Object { | ||
| "bcc": Array [ | ||
| "[email protected]", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,9 @@ import axios from 'axios'; | |
| import { createExternalService } from './service'; | ||
| import * as utils from '../lib/axios_utils'; | ||
| import { ExternalService } from '../case/types'; | ||
| import { Logger } from '../../../../../../src/core/server'; | ||
| import { loggingSystemMock } from '../../../../../../src/core/server/mocks'; | ||
| const logger = loggingSystemMock.create().get() as jest.Mocked<Logger>; | ||
|
|
||
| jest.mock('axios'); | ||
| jest.mock('../lib/axios_utils', () => { | ||
|
|
@@ -26,10 +29,13 @@ describe('Jira service', () => { | |
| let service: ExternalService; | ||
|
|
||
| beforeAll(() => { | ||
| service = createExternalService( | ||
| { | ||
| config: { apiUrl: 'https://siem-kibana.atlassian.net', projectKey: 'CK' }, | ||
| secrets: { apiToken: 'token', email: '[email protected]' }, | ||
| }, | ||
| logger | ||
| ); | ||
| }); | ||
|
|
||
| beforeEach(() => { | ||
|
|
@@ -39,37 +45,49 @@ describe('Jira service', () => { | |
| describe('createExternalService', () => { | ||
| test('throws without url', () => { | ||
| expect(() => | ||
| createExternalService( | ||
| { | ||
| config: { apiUrl: null, projectKey: 'CK' }, | ||
| secrets: { apiToken: 'token', email: '[email protected]' }, | ||
| }, | ||
| logger | ||
| ) | ||
| ).toThrow(); | ||
| }); | ||
|
|
||
| test('throws without projectKey', () => { | ||
| expect(() => | ||
| createExternalService( | ||
| { | ||
| config: { apiUrl: 'test.com', projectKey: null }, | ||
| secrets: { apiToken: 'token', email: '[email protected]' }, | ||
| }, | ||
| logger | ||
| ) | ||
| ).toThrow(); | ||
| }); | ||
|
|
||
| test('throws without username', () => { | ||
| expect(() => | ||
| createExternalService( | ||
| { | ||
| config: { apiUrl: 'test.com' }, | ||
| secrets: { apiToken: '', email: '[email protected]' }, | ||
| }, | ||
| logger | ||
| ) | ||
| ).toThrow(); | ||
| }); | ||
|
|
||
| test('throws without password', () => { | ||
| expect(() => | ||
| createExternalService( | ||
| { | ||
| config: { apiUrl: 'test.com' }, | ||
| secrets: { apiToken: '', email: undefined }, | ||
| }, | ||
| logger | ||
| ) | ||
| ).toThrow(); | ||
| }); | ||
| }); | ||
|
|
@@ -92,6 +110,7 @@ describe('Jira service', () => { | |
| expect(requestMock).toHaveBeenCalledWith({ | ||
| axios, | ||
| url: 'https://siem-kibana.atlassian.net/rest/api/2/issue/1', | ||
| logger, | ||
| }); | ||
| }); | ||
|
|
||
|
|
@@ -146,6 +165,7 @@ describe('Jira service', () => { | |
| expect(requestMock).toHaveBeenCalledWith({ | ||
| axios, | ||
| url: 'https://siem-kibana.atlassian.net/rest/api/2/issue', | ||
| logger, | ||
| method: 'post', | ||
| data: { | ||
| fields: { | ||
|
|
@@ -210,6 +230,7 @@ describe('Jira service', () => { | |
|
|
||
| expect(requestMock).toHaveBeenCalledWith({ | ||
| axios, | ||
| logger, | ||
| method: 'put', | ||
| url: 'https://siem-kibana.atlassian.net/rest/api/2/issue/1', | ||
| data: { fields: { summary: 'title', description: 'desc' } }, | ||
|
|
@@ -272,6 +293,7 @@ describe('Jira service', () => { | |
|
|
||
| expect(requestMock).toHaveBeenCalledWith({ | ||
| axios, | ||
| logger, | ||
| method: 'post', | ||
| url: 'https://siem-kibana.atlassian.net/rest/api/2/issue/1/comment', | ||
| data: { body: 'comment' }, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems slightly odd that the package names got resorted here, though it looks like they sorted CORRECTLY now, and weren't before. Like someone previously edited the file manually. It's just
@types/packages anyway though, so not a big deal, and it looks fine to me.