[build] Cleanup dirs on uninstall #7422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM I did a local build of ospackages on Ubuntu and installed the 64-bit deb package with I started and stopped Kibana service, and tried to install some plugins but nothing was compatible with this snapshot. I uninstalled with I reinstalled, started/stopped the service, and then uninstalled with |
|
jenkins, test it |
|
Any reason not to backport this to 4.6? |
|
LGTM |
|
Nope, this would be good to backport. |
elastic-jasper
added a commit
that referenced
this pull request
Jun 16, 2016
--------- **Commit 1:** [build] Cleanup dirs on uninstall * Original sha: 29e26de * Authored by Jonathan Budzenski <[email protected]> on 2016-05-25T22:05:28Z
jbudz
added a commit
that referenced
this pull request
Jun 17, 2016
--------- **Commit 1:** [build] Cleanup dirs on uninstall * Original sha: 29e26de * Authored by Jonathan Budzenski <[email protected]> on 2016-05-25T22:05:28Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[build] Cleanup dirs on uninstall Former-commit-id: 314e095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On package purge or removal, this cleans up the installed/generated files in the optimize and plugins dirs