Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Load prepackage timelines by default #74209

Merged
merged 2 commits into from
Aug 4, 2020
Merged

[Security Solution] Load prepackage timelines by default #74209

merged 2 commits into from
Aug 4, 2020

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Aug 4, 2020 •
edited
Loading

Summary

As we want to show the elastic templates once users landing on template’s tab, but since few weeks ago it stops showing elastic templates automatically.
This PR is to fix the issue and load Elastic prebuilt templates by default.

How to verify this PR:

case one:

  1. cd x-pack/plugins/security_solution/server/lib/detection_engine/scripts
  2. sh timelines/delete_all_timelines.sh
  3. go to timeline's tab, clicking on templates, and make sure elastic templates are loaded by default

case two:

  1. cd x-pack/plugins/security_solution/server/lib/detection_engine/scripts
  2. sh timelines/delete_all_timelines.sh
  3. go to host page (or any page with timeline's flyout but don't go to timelines' page), clicking on the flyout > gear > open timeline, and make sure elastic templates are loaded by default

@angorayc angorayc added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Aug 4, 2020
@angorayc angorayc requested review from a team as code owners August 4, 2020 00:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB -1.0B 7.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cnasikas
cnasikas approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I followed the testing instructions and everything is working fine!

I noticed that when you change tabs between Timelines and Templates a call is being made to the api/timeline/_prepackaged route. I think we should make one call only when the user navigates for the first time on the Timeline page. Let's create an issue to track this. What do you think?

Also, when you click Open timeline... button the Only timelines filter is selected. Is that intended?

@angorayc
Copy link
Contributor Author

angorayc commented Aug 4, 2020

LGTM! I followed the testing instructions and everything is working fine!

I noticed that when you change tabs between Timelines and Templates a call is being made to the api/timeline/_prepackaged route. I think we should make one call only when the user navigates for the first time on the Timeline page. Let's create an issue to track this. What do you think?

Also, when you click Open timeline... button the Only timelines filter is selected. Is that intended?

Thanks @cnasikas , yeah, that's expected behaviour, I did that in #74051

@angorayc
Copy link
Contributor Author

angorayc commented Aug 4, 2020

LGTM! I followed the testing instructions and everything is working fine!

I noticed that when you change tabs between Timelines and Templates a call is being made to the api/timeline/_prepackaged route. I think we should make one call only when the user navigates for the first time on the Timeline page. Let's create an issue to track this. What do you think?

I think we can leave it like this until the prebuilt templates grows more. We can cancel the auto load entirely and put a load elastic prebuilt templates button there.

@angorayc angorayc merged commit b42f64d into elastic:master Aug 4, 2020
angorayc added a commit to angorayc/kibana that referenced this pull request Aug 4, 2020
@angorayc
[Security Solution] Load prepackage timelines by default (elastic#74209)
b210672 
* load prepackage timelines by default

* fix unit tests
This was referenced Aug 4, 2020
Merged
Merged
angorayc added a commit to angorayc/kibana that referenced this pull request Aug 4, 2020
@angorayc
[Security Solution] Load prepackage timelines by default (elastic#74209)
f09c87c 
* load prepackage timelines by default

* fix unit tests
angorayc added a commit that referenced this pull request Aug 4, 2020
@angorayc
[Security Solution] Load prepackage timelines by default (#74209) (#7…
cdfcd53 
…4267)

* load prepackage timelines by default

* fix unit tests
angorayc added a commit that referenced this pull request Aug 4, 2020
@angorayc
[Security Solution] Load prepackage timelines by default (#74209) (#7…
28f1110 
…4266)

* load prepackage timelines by default

* fix unit tests
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@angorayc @elasticmachine @kibanamachine @cnasikas @MindyRS