Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Disable auto-refresh by default #74068

Merged
merged 1 commit into from
Aug 3, 2020
Merged

[APM] Disable auto-refresh by default #74068

merged 1 commit into from
Aug 3, 2020

Conversation

dgieselaar
Copy link
Member

Closes #73439.

@dgieselaar dgieselaar added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes 7.9.0 labels Aug 3, 2020
@dgieselaar dgieselaar requested a review from a team as a code owner August 3, 2020 10:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

dgieselaar
dgieselaar commented Aug 3, 2020
View reviewed changes
x-pack/plugins/apm/public/components/shared/DatePicker/__test__/DatePicker.test.tsx
@@ -64,35 +64,33 @@ describe('DatePicker', () => {
});

beforeEach(() => {
jest.clearAllMocks();
jest.resetAllMocks();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearAllMocks only clears the calls, not the state. Some of the state from previous tests was leaking into others.

cauemarcondes
cauemarcondes approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
apm 3.7MB -193.0B 3.7MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit 7099a6d into elastic:master Aug 3, 2020
@dgieselaar dgieselaar deleted the auto-refresh-default-disabled branch August 3, 2020 12:49
kibanamachine pushed a commit that referenced this pull request Aug 3, 2020
@dgieselaar
[APM] Disable auto-refresh by default (#74068)
e7cf68a
@kibanamachine kibanamachine mentioned this pull request Aug 3, 2020
Merged
kibanamachine pushed a commit that referenced this pull request Aug 3, 2020
@dgieselaar
[APM] Disable auto-refresh by default (#74068)
b18a529
@kibanamachine kibanamachine mentioned this pull request Aug 3, 2020
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

The PR was backported to the following branches:

dgieselaar added a commit that referenced this pull request Aug 3, 2020
@kibanamachine @dgieselaar
[7.x] [APM] Disable auto-refresh by default (#74068) (#74077)
d8ae9a6 
Co-authored-by: Dario Gieselaar <[email protected]>
dgieselaar added a commit that referenced this pull request Aug 3, 2020
@kibanamachine @dgieselaar
[7.9] [APM] Disable auto-refresh by default (#74068) (#74078)
1406b37 
Co-authored-by: Dario Gieselaar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.9.0 v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Don't enable auto-refresh by default
4 participants
@dgieselaar @elasticmachine @kibanamachine @cauemarcondes