Add screenshot-comparison utility, to protect against visual regressions during CSS refactors. #7395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,7 +12,12 @@ target | |||
| .idea | |||
| *.iml | |||
| *.log | |||
| /test/output | |||
| /test/screenshots/diff/**/* | |||
| !/test/screenshots/diff/.empty | |||
There was a problem hiding this comment.
I suggest using mkdirp.sync(dirname(path)) before saving. It's more future proof and less messy that way.
|
Looking good |
| shadow: true, | ||
| }, function (comparisonError, result) { | ||
| if (comparisonError) { | ||
| return console.log(comparisonError); |
There was a problem hiding this comment.
If this is a CLI tool I would just throw comparisonError.
cjcenizal
force-pushed
the
feature/compare-screenshots-utility
branch
from
07aa5a3 to
8f8b82e
Compare
| var self = this; | ||
| var testName = (testObj.parent) ? [testObj.parent.name, testObj.name].join('_') : testObj.name; | ||
| handleError(testObj) { | ||
| const self = this; |
There was a problem hiding this comment.
one more self to get rid of, sorry
|
LGTM |
| const screenshot = await this.remote.takeScreenshot(); | ||
| mkdirp.sync(directoryPath); | ||
| fs.writeFileSync(filePath, screenshot); | ||
| } catch (err) { |
There was a problem hiding this comment.
Probable move catch clause one level up, so we saveScreenshot.catch(reason => console.log(reason)). Leave error handling to consumer
|
Few style comments but LGTM otherwise |
cjcenizal
force-pushed
the
feature/compare-screenshots-utility
branch
3 times, most recently
from
193dde3 to
eb5618d
Compare
…ons during CSS refactors. - Remove test/output and added test/screenshots (requires a Jenkins change). - Add test/screenshots/baseline images. These document the expected state of the UI. - Add dependency on image-diff package. - Add utilities/compareScreenshots.js, which can be run via 'npm run compareScreenshots'.
cjcenizal
force-pushed
the
feature/compare-screenshots-utility
branch
from
eb5618d to
9fa2e82
Compare
|
@spalger Looks like Jenkins is pushing the S3 artifacts! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reference
Based upon #7382