Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Functional Test ] Unskip X-Pack "Advanced Settings - spaces feature controls" suite #73823

Merged
merged 3 commits into from
Aug 3, 2020
Merged

[ Functional Test ] Unskip X-Pack "Advanced Settings - spaces feature controls" suite #73823

merged 3 commits into from
Aug 3, 2020

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jul 30, 2020 •
edited
Loading

Summary

It was not my merit to fix the issue related to this test, rather testing thoroughly it has been fixed and no longer flaky. :)

Flaky test runner tip:
do not set 300 executions on the flaky test runner, it will timeout, expecially with the X-pack groups. Set 3 independent runs of 100 executions each. :)

Closes #57413

Checklist

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.10.0 labels Jul 30, 2020
@dej611 dej611 self-assigned this Jul 30, 2020
@dej611 dej611 added the release_note:skip Skip the PR/issue when compiling release notes label Jul 30, 2020
@dej611
Copy link
Contributor Author

dej611 commented Jul 30, 2020

@elasticmachine merge upstream

@dej611 dej611 requested a review from spalger July 31, 2020 08:52
@dej611 dej611 marked this pull request as ready for review July 31, 2020 12:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

spalger
spalger approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for putting in the work and verifying that this runs well

@dej611
Copy link
Contributor Author

dej611 commented Aug 3, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit 1b2233a into elastic:master Aug 3, 2020
@dej611 dej611 deleted the fix/57413-2 branch August 3, 2020 10:16
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 73823 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 5, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 73823 or prevent reminders by adding the backport:skip label.

6 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 73823 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 73823 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 73823 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 73823 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 73823 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 73823 or prevent reminders by adding the backport:skip label.

@dej611 dej611 mentioned this pull request Aug 17, 2020
Merged
dej611 added a commit to dej611/kibana that referenced this pull request Aug 17, 2020
@dej611 @elasticmachine
[ Functional Test ] Unskip X-Pack "Advanced Settings - spaces feature…
dbd3e32 
… controls" suite (elastic#73823)

Co-authored-by: Elastic Machine <[email protected]>
dej611 added a commit that referenced this pull request Aug 17, 2020
@dej611 @elasticmachine
[7.x] [ Functional Test ] Unskip X-Pack "Advanced Settings - spaces f…
d35ffbb 
…eature controls" suite (#73823) (#75132)

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees

@dej611 dej611

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@dej611 @elasticmachine @kibanamachine @spalger