Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution]Updates exception options and setting text #73769

Merged
merged 3 commits into from
Aug 4, 2020

Conversation

benskelker
Copy link
Contributor

Summary

Updates the options and setting text when adding exceptions to rules, including when creating and modifying rules:

Alert dropdown:

ex via lert new

Elastic Endpoint rule:

new ex dropdown

Create/modify rule:

rule setting ex

Checklist

Delete any items that are not applicable to this PR.

@benskelker benskelker added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 7.9.0 labels Jul 30, 2020
@benskelker benskelker requested review from a team as code owners July 30, 2020 06:30
@benskelker
Copy link
Contributor Author

@peluja1012 @dontcallmesherryli @spong
Maybe we should change this text as well:
'Any file in quarantine on any endpoint that matches the attribute(s) selected will automatically be restored to its original location. This exception will apply to any rule that is linked to the Global Endpoint Exception List.'

To something like:

On all Endpoint hosts, quarantined files that match the exception are automatically restored to their original locations. This exception applies to all rules using Endpoint exceptions.

@benskelker benskelker requested a review from MikePaquette July 30, 2020 07:15
@spalger spalger added v7.9.0 and removed 7.9.0 labels Jul 30, 2020
@peluja1012
Copy link
Contributor

Maybe we should change this text as well:

@benskelker I like you suggestion. Good catch!

@benskelker
Copy link
Contributor Author

@peluja1012 - committed the modal text change:
Screenshot 2020-08-04 at 10 22 14

@benskelker
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB -88.0B 7.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@peluja1012 peluja1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ben!

@benskelker benskelker merged commit f3fbb7d into elastic:master Aug 4, 2020
@benskelker benskelker deleted the update-exceptions-ui-text branch August 4, 2020 14:43
benskelker added a commit to benskelker/kibana that referenced this pull request Aug 4, 2020
…c#73769)

* updates exception text

* updates modal text

Co-authored-by: Elastic Machine <[email protected]>
benskelker added a commit that referenced this pull request Aug 4, 2020
#74258)

* updates exception text

* updates modal text

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
benskelker added a commit that referenced this pull request Aug 4, 2020
#74259)

* updates exception text

* updates modal text

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants