[kbn/optimizer] restore x-pack bundle banner #73767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-operations (Team:Operations) |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jul 30, 2020
Co-authored-by: spalger <[email protected]>
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jul 30, 2020
Co-authored-by: spalger <[email protected]> # Conflicts: # packages/kbn-optimizer/src/integration_tests/__snapshots__/basic_optimization.test.ts.snap
This was referenced Jul 30, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jul 30, 2020
Co-authored-by: spalger <[email protected]> # Conflicts: # packages/kbn-optimizer/src/common/bundle.ts # packages/kbn-optimizer/src/integration_tests/__snapshots__/basic_optimization.test.ts.snap # packages/kbn-optimizer/src/integration_tests/basic_optimization.test.ts # packages/kbn-optimizer/src/optimizer/get_plugin_bundles.ts # packages/kbn-optimizer/src/worker/webpack.config.ts
spalger
added a commit
that referenced
this pull request
Jul 30, 2020
Co-authored-by: spalger <[email protected]> Co-authored-by: spalger <[email protected]>
spalger
added a commit
that referenced
this pull request
Jul 30, 2020
Co-authored-by: spalger <[email protected]>
spalger
added a commit
that referenced
this pull request
Jul 30, 2020
Co-authored-by: spalger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added the
@kbn/optimizerI failed to bring over the custom webpack config that powered the Elastic license header in the built version of the x-pack bundles. This license header isn't strictly necessary, but we keep it there regardless so that people who inspect the files know what they're looking at.