[ML] DF Analytics creation wizard: ensure user can switch back to form from JSON editor #73752
Conversation
alvarezmelissa87
added
release_note:enhancement
:ml
Feature:Data Frame Analytics
|
Pinging @elastic/ml-ui (:ml) |
alvarezmelissa87
requested review from
peteharverson,
walterra and
jgowdyelastic
alvarezmelissa87
force-pushed
the
ml-dfanalytics-switch-back-to-form
branch
from
8bb390d to
77762e2
Compare
|
As discussed, is it possible to disable the switch back to the form editor if you add an unsupported field into the
An error is triggered once you are back in the form editor, and if you then switch again to the JSON editor the switch becomes disabled. @peteharverson - thanks for taking a look! I think I'll address that in a follow up as it might require a bit of refactor so we don't do a full validation every single time the config string changes, as that would be a bit too much. |
alvarezmelissa87
force-pushed
the
ml-dfanalytics-switch-back-to-form
branch
from
77762e2 to
369ad8e
Compare
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
| case ACTION.SWITCH_TO_FORM: | ||
| const { jobConfig: config, jobIds } = state; | ||
| const { jobId } = state.form; | ||
| // @ts-ignore |
There was a problem hiding this comment.
Can you explain and add a comment why the ignore is necessary? Do you plan to solve it in a follow up?
There was a problem hiding this comment.
The ignore is necessary because of the differences in CloneDataFrameAnalyticsConfig vs DataFrameAnalyticsConfig - particularly the allowance of some of those values being undefined when just switching back from the JSON editor (as when it's a cloned job, all the values must be defined). I plan to solve it in a follow-up.
| return validateForm({ | ||
| ...state, | ||
| // @ts-ignore | ||
| form: formState, |
There was a problem hiding this comment.
Can you explain and add a comment why the ignore is necessary? Do you plan to solve it in a follow up?
There was a problem hiding this comment.
Same as above.
…m from JSON editor (elastic#73752) * wip: add reducer action to switch to form * rename getFormStateFromJobConfig * wip: types fix * show destIndex input when switching back from editor * ensure validation up to date when switching to form * cannot switch back to form if advanced config * update types * localization fix
…m from JSON editor (#73752) (#73950) * wip: add reducer action to switch to form * rename getFormStateFromJobConfig * wip: types fix * show destIndex input when switching back from editor * ensure validation up to date when switching to form * cannot switch back to form if advanced config * update types * localization fix
Summary
Related meta issue: #66661
This PR allows the user to switch back and forth from the JSON editor and form.
Running flaky test runner to ensure functional tests not affected: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/711/
Checklist
Delete any items that are not applicable to this PR.