Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate timepicker:timeDefaults ui setting to the data plugin. #73750

Merged
merged 5 commits into from
Aug 3, 2020
Merged

Migrate timepicker:timeDefaults ui setting to the data plugin. #73750

merged 5 commits into from
Aug 3, 2020

Conversation

lukeelmers
Copy link
Member

Blocks #56205
Part of #63459

When we previously migrated UI Settings to the data plugin, we must have missed this one:

  • Moves timepicker:timeDefaults to the data plugin
  • Updates a few places where the setting name is used as a string and replaces it with the const exported from the data plugin

@lukeelmers lukeelmers requested review from flash1293 and a team July 29, 2020 22:04
@lukeelmers lukeelmers requested a review from a team as a code owner July 29, 2020 22:04
@lukeelmers lukeelmers requested a review from a team July 29, 2020 22:04
@lukeelmers lukeelmers self-assigned this Jul 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers mentioned this pull request Jul 29, 2020
Closed
lizozom
lizozom approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chrisronline
chrisronline approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukeelmers
Copy link
Member Author

@elasticmachine merge upstream

@lukeelmers
Copy link
Member Author

@elasticmachine merge upstream

wylieconlon
wylieconlon approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not run the code, but the change LGTM. Looks like there's a real failure.

src/plugins/data/server/ui_settings.ts Outdated Show resolved Hide resolved
@lukeelmers lukeelmers removed the request for review from flash1293 August 3, 2020 20:20
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
data 1.4MB +42.0B 1.4MB
monitoring 294.9KB +27.0B 294.9KB
total - +69.0B -

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lukeelmers lukeelmers merged commit 06412ae into elastic:master Aug 3, 2020
@lukeelmers lukeelmers deleted the fix/migrate-timedefaults branch August 3, 2020 21:43
@lukeelmers lukeelmers mentioned this pull request Aug 4, 2020
Merged
lukeelmers added a commit that referenced this pull request Aug 5, 2020
@lukeelmers
Migrate timepicker:timeDefaults ui setting to the data plugin. (#73750)…
87cfa3f 
… (#74315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizozom lizozom lizozom approved these changes

@wylieconlon wylieconlon wylieconlon approved these changes

@chrisronline chrisronline chrisronline approved these changes

Assignees

@lukeelmers lukeelmers

Labels
chore Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes review v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lukeelmers @elasticmachine @kibanamachine @chrisronline @wylieconlon @lizozom