-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update alert type selection layout to rows instead of grid #73665
Merged
Merged
Changes from 2 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
64afacd
Update layout to rows for alert types
mdefazio 923d398
Fix gutter usage
mdefazio 1ed453b
Merge branch 'master' of github.com:elastic/kibana into alerting-desi…
mdefazio 9f87047
Update heading, remove icons
mdefazio afd6cb4
Non-working update to the combo box
mdefazio 2340875
Merge branch 'master' of github.com:elastic/kibana into alerting-desi…
mdefazio 9721af1
Add incorrect updates with questions to fix
mdefazio e4f5ee3
Merge branch 'master' of github.com:elastic/kibana into alerting-desi…
mdefazio 5ab4a7d
Fix combo box
mdefazio e371b53
Cleanup changes to specific to this module
mdefazio 8c97177
Merge remote-tracking branch 'upstream/master' into alerting-design-u…
YulNaumenko 50d565e
fixed type checks and made combobox always visible
YulNaumenko 0ce9e8e
Added groups by producer
YulNaumenko bca7924
Merge remote-tracking branch 'upstream/master' into alerting-design-u…
YulNaumenko 11ffae0
Added get producer name from kibana features names
YulNaumenko d8f3ae1
Merge remote-tracking branch 'upstream/master' into alerting-design-u…
YulNaumenko 5634fc6
Added search bar with list of alert types
YulNaumenko 7ace8d7
Added search support functionality
YulNaumenko db42de7
Merge remote-tracking branch 'upstream/master' into alerting-design-u…
YulNaumenko e45c7de
fixed links to alert type
YulNaumenko 239712e
added alert type title
YulNaumenko 850a030
Fixed failing tests
YulNaumenko 00bfb1c
Design updates to list
mdefazio 489ee44
Remove unsed items in import list
mdefazio 22db484
Merge remote-tracking branch 'upstream/master' into alerting-design-u…
YulNaumenko 8ba2a3f
fixed merge issue
YulNaumenko 9d5595d
Fixed due to comments
YulNaumenko ae9faba
fixed tests
YulNaumenko 6a96a4e
Design fixes
mdefazio e6ced0d
Merge branch 'alerting-design-updates' of github.com:mdefazio/kibana …
mdefazio a197fcf
Merge remote-tracking branch 'upstream/master' into alerting-design-u…
YulNaumenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be simpler here to reduce
availableAlertTypesResult
instead ofalertTypesResult
since that is already filtered down to the available?