allow others to update URL.revokeObjectURL property if needed
#73639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:SIEM
v8.0.0
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
andrew-goldstein
approved these changes
Jul 29, 2020
2 tasks
|
@elasticmachine merge upstream |
|
The |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
mshustov
pushed a commit
to mshustov/kibana
that referenced
this pull request
Jul 29, 2020
…tic#73639) Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
mistic
pushed a commit
to mistic/kibana
that referenced
this pull request
Jul 29, 2020
…tic#73639) Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
mistic
pushed a commit
to mistic/kibana
that referenced
this pull request
Jul 29, 2020
…tic#73639) Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
mshustov
added a commit
that referenced
this pull request
Jul 29, 2020
…) (#73661) Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Spencer <[email protected]> Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 29, 2020
* master: (126 commits) [ML] Disabling ML if license feature is disabled (elastic#73187) [ML] Fixing old _xpack style es endpoint paths (elastic#73667) [DOCS] [Lens] 7.9 docs refresh (elastic#72301) [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539) Set timeRange to default to trigger the error message (elastic#73629) [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660) [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473) [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320) [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969) [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618) allow others to update `URL.revokeObjectURL` property if needed (elastic#73639) regen docs (elastic#73650) [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605) [Data] Query Input String manager (elastic#72093) [Security Solutions] Add tooltips (elastic#73436) Do not render descriptionless actions within an EuiCard (elastic#73611) [Security Solution][Detections] Value Lists Modal supports multiple exports (elastic#73532) [Security Solution][Resolver] Handle disabled process collection (elastic#73592) [Security_Solution][Bug] Fix user name/domain to ECS structure (elastic#73530) [Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id (elastic#73349) ...
mistic
added a commit
that referenced
this pull request
Jul 29, 2020
…) (#73664) Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Spencer <[email protected]> Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 30, 2020
…ibana into actions/webhook-remove-header * 'actions/webhook-remove-header' of github.com:gmmorris/kibana: (86 commits) [maps] rename GisMap to MapContainer and convert to TS (elastic#73690) [APM] docs: remove watcher documentation (elastic#73485) [Maps] fix fit to data for Point to Point layer (elastic#73563) [Metrics UI] Fix No Data in Inventory alerts/Snapshot API (elastic#72513) [ML] Disabling ML if license feature is disabled (elastic#73187) [ML] Fixing old _xpack style es endpoint paths (elastic#73667) [DOCS] [Lens] 7.9 docs refresh (elastic#72301) [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539) Set timeRange to default to trigger the error message (elastic#73629) [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660) [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473) [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320) [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969) [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618) allow others to update `URL.revokeObjectURL` property if needed (elastic#73639) regen docs (elastic#73650) [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605) [Data] Query Input String manager (elastic#72093) [Security Solutions] Add tooltips (elastic#73436) Do not render descriptionless actions within an EuiCard (elastic#73611) ...
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73630
Fixes #73631
#73532 added a stub
revokeObjectURLimplementation as recommended in places like jsdom/jsdom#1721 (comment), this seems to cause a race condition if some Jest workers are running faster than others and the tests in x-pack/plugins/security_solution/public/detections/components/value_lists_management_modal/auto_download.test.tsx execute first in the same worker that x-pack/plugins/reporting/public/panel_actions/get_csv_panel_action.test.ts executes in later.This seems to have caused the failure in https://kibana-ci.elastic.co/job/elastic+kibana+master/7002/ but the tests passed in https://kibana-ci.elastic.co/job/elastic+kibana+master/7003/ but we don't have any visibility into the workers that tests are assigned to.
Based on my reading of
JestRuntime#teardown()andJestRuntime#resetModules()it doesn't seem thatwindow.URLis reset between tests so this somewhat unproven theory seems to make sense.