Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Data] Query Input String manager (#72093) #73634

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Jul 29, 2020

Backports the following commits to 7.x:

* improve test stability

* query string input manager (needed for search demo)

* docs

* dashboard

* Fix jest

* mock fix

* Allow restoring a saved query

* sync url

* Luke's fix to test

* cleanup

* lens jest tests

* docs

* use queryStringManager.getDefaultQuery
Don't sync query to global state

* Update app.test.tsx

lens mock

* jest fix

* jest

* use new api in the example

* Rename state param to query to match url state

* Apply changes to discover

* Update src/plugins/data/public/query/query_string/index.ts

Co-authored-by: Anton Dosov <[email protected]>

* Improve query string state manager

* Cleanup dashboard code

* Handle refresh button

* Set initial dashboard state

* visualize state

* remove unused

* docs

* fix example

* fix jest

* fix filter app state in discover

* fix maps test

* jest

Co-authored-by: Anton Dosov <[email protected]>
Co-authored-by: Anton Dosov <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	src/plugins/data/public/public.api.md
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
discover 430.9KB -280.0B 431.2KB
indexPatternManagement 697.9KB -45.0B 698.0KB
lens 24.7KB -204.0B 24.9KB
maps 3.8MB -150.0B 3.8MB
visualize 677.3KB -372.0B 677.7KB
total - -1.0KB -

page load bundle size

id value diff baseline
charts 874.0KB -40.0B 874.1KB
dashboard 679.7KB -338.0B 680.0KB
data 1.4MB +3.2KB 1.4MB
regionMap 832.6KB -40.0B 832.6KB
tileMap 844.2KB -40.0B 844.3KB
visTypeMarkdown 553.2KB -40.0B 553.2KB
visTypeMetric 576.2KB -40.0B 576.3KB
visTypeTable 605.0KB -40.0B 605.0KB
visTypeTagcloud 837.4KB -40.0B 837.5KB
visTypeTimelion 712.9KB -40.0B 713.0KB
visTypeVega 661.0KB -40.0B 661.0KB
visTypeVislib 1.3MB -40.0B 1.3MB
total - +2.5KB -

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lizozom lizozom merged commit 25ceed9 into elastic:7.x Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants