-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
theme function #73451
Merged
Merged
theme function #73451
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4a38577
theme function
ppisljar 64c4dcc
fixing i18n
ppisljar d90c347
fixing tests
ppisljar e9bb13a
Merge branch 'master' into expressions/theming
ppisljar 18acd74
Update src/plugins/expressions/common/expression_functions/specs/them…
ppisljar 19b2ab0
Merge branch 'master' into expressions/theming
elasticmachine 2658d66
adding test
ppisljar 73979df
Merge branch 'expressions/theming' of https://github.com/ppisljar/kib…
ppisljar 9acb737
updating
ppisljar a384284
Merge branch 'master' into expressions/theming
ppisljar 6fd6675
fixing test
ppisljar 2265a21
updating type
ppisljar 3aef92a
Merge branch 'master' into expressions/theming
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
src/plugins/expressions/common/expression_functions/specs/tests/theme.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { functionWrapper } from './utils'; | ||
import { theme } from '../theme'; | ||
import { ExecutionContext } from '../../../execution/types'; | ||
import { KibanaContext } from '../../../expression_types'; | ||
|
||
describe('expression_functions', () => { | ||
describe('theme', () => { | ||
const fn = functionWrapper(theme); | ||
let context: ExecutionContext; | ||
|
||
let themeProps; | ||
|
||
beforeEach(() => { | ||
themeProps = { | ||
font: { | ||
family: 'Arial', | ||
size: 14, | ||
}, | ||
}; | ||
|
||
context = { | ||
getInitialInput: () => input, | ||
types: {}, | ||
variables: { theme: themeProps }, | ||
abortSignal: {} as any, | ||
inspectorAdapters: {} as any, | ||
}; | ||
}); | ||
|
||
it('returns the selected variable', () => { | ||
const actual = fn(null, { variable: 'font.family' }, context); | ||
expect(actual).toEqual('Arial'); | ||
}); | ||
|
||
it('returns undefined if variable does not exist', () => { | ||
const actual = fn(null, { variable: 'font.weight' }, context); | ||
expect(actual).toEqual(undefined); | ||
}); | ||
|
||
it('returns default if variable does not exist and default is provided', () => { | ||
const actual = fn(null, { variable: 'font.weight', default: 'normal' }, context); | ||
expect(actual).toEqual('normal'); | ||
}); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit here -- it would be cool to add an integration test for
font
that actually validates the correct default value is applied viatheme
, based on whether or not you have set the appropriate variable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that won't be possible due to the way interpreter works:
here we are just testing the font function without interpreter and providing arguments in. to do integration test we would need interpreter service running (with the registries and everything) which i think is hard at the moment.