Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.9] [SIEM][Timelines] Updates timeline template callout text (#73334) #73417

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

MadameSheema
Copy link
Member

Backports the following commits to 7.9:

* updates timeline template callout text

* fixes typo in constant

Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / "after each" hook for "toggles open the timeline".timeline flyout button "after each" hook for "toggles open the timeline"

Link to Jenkins

Stack Trace

CypressError: Timed out retrying: `cy.click()` could not be issued because this element is currently animating:

`<button class="euiButtonEmpty euiButtonEmpty--text" type="button" data-test-subj="timeline-new">...</button>`

You can fix this problem by:
  - Passing `{force: true}` which disables all error checking
  - Passing `{waitForAnimations: false}` which disables waiting on animations
  - Passing `{animationDistanceThreshold: 20}` which decreases the sensitivity

https://on.cypress.io/element-is-animating

Because this error occurred during a `after each` hook we are skipping the remaining tests in the current suite: `timeline flyout button`
    at cypressErr (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:146621:16)
    at cypressErrByPath (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:146630:10)
    at Object.throwErrByPath (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:146593:11)
    at Object.ensureElementIsNotAnimating (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:137560:24)
    at ensureNotAnimating (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:127434:13)
    at runAllChecks (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:127522:9)
    at retryActionability (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:127542:16)
    at tryCatcher (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:9065:23)
    at Function.Promise.attempt.Promise.try (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:6339:29)
    at tryFn (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:140680:21)
    at whenStable (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:140715:12)
    at http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:140259:16
    at tryCatcher (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:9065:23)
    at Promise._settlePromiseFromHandler (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:7000:31)
    at Promise._settlePromise (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:7057:18)
    at Promise._settlePromise0 (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:7102:10)

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MadameSheema MadameSheema merged commit 6ebdda5 into elastic:7.9 Jul 28, 2020
@MadameSheema MadameSheema deleted the backport/7.9/pr-73334 branch July 28, 2020 10:57
tylersmalley pushed a commit that referenced this pull request Jul 28, 2020
@tylersmalley
Copy link
Contributor

This was the first failure of this tests and is now failing on the 7.9 branch. I am not sure why the changes here would result in that failure, but I have reverted it in the meantime.

7.9: f615e67

@tylersmalley
Copy link
Contributor

Re-backported (aee35b8) - security team is skipping the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants