[fix] Adding new visualization when session storage enabled

[ThomThomson]

Summary

Closes #73013

The above issue was caused by the conflict between browserHistory and hashHistory, where subscribing to hashHistory clears the history.location.state. The following code sandbox illustrates the problem.

When store in session storage is enabled, the location state is cleared prior to the creation of the dashboard container, which resulted in no embeddable being added. Once #65614 is closed, and angular routing is removed from dashboard, the location state should no longer be cleared.
Once we have switched away from using hash routing #67470, this issue should be resolved.

In the meantime, this workaround loads the incomingEmbeddable much earlier in the dashboard_app_controller's constructor.

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[flash1293]

Tested in Chrome and Firefox, adding and editing Lens and Visualize panels works fine with session storage enabled.

Once #65614 is closed, and angular routing is removed from dashboard, the location state should no longer be cleared.

Are you sure about that? We are using hash history outside of Angular as well for the state syncing, it probably has the same issue of losing the incoming state.

One reason more to switch away from hash routing completely soon in the near future :)

[ThomThomson]

A cursory look into lens and the deangularized visualize suggested that they didn't suffer from the same problem, but I've done a bit more digging, and it looks like you're right @flash1293. This shows the problem showing up in visualize:

Longer term, is the goal to move towards browser history? Is there an issue set up to track this?

If not, I am wondering if we should consider session storage as a more stable alternative for the state transfer service.

[flash1293]

@ThomThomson There is a toplevel issue here: #67470

[kibanamachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: affd65b
• Pipeline Steps (look for red circles / failed steps)
• Interpreting CI Failures

Failed CI Steps

• Execute x-pack-intake

---

Test Failures

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/uptime/public/components/common/charts/__tests__.PingHistogram component renders the component without errors

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 8 times on tracked branches: https://github.com/elastic/kibana/issues/73522

Stack Trace

Error: expect(received).toMatchSnapshot()

Snapshot name: `PingHistogram component renders the component without errors 1`

- Snapshot  - 1
+ Received  + 1

@@ -3,11 +3,11 @@
      class="euiTitle euiTitle--xsmall"
    >
      Pings over time
    </h2>,
    <div
-     aria-label="Bar Chart showing uptime status over time from a year ago to a year ago."
+     aria-label="Bar Chart showing uptime status over time from 2 years ago to 2 years ago."
      style="height:100%;opacity:1;transition:opacity 0.2s"
    >
      <div
        class="echChart"
      >
    at Object.it (/dev/shm/workspace/kibana/x-pack/plugins/uptime/public/components/common/charts/__tests__/ping_histogram.test.tsx:58:23)
    at Promise (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:198:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:162:10)
    at _callCircusTest (/dev/shm/workspace/kibana/node_modules/jest-circus/build/run.js:205:40)
    at process._tickCallback (internal/process/next_tick.js:68:7)

---

Build metrics

page load bundle size

id	value	diff	baseline
dashboard	678.9KB	+40.0B	678.9KB

History

• 💚 Build #64505 succeeded affd65b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream