Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Fix focus map link on service map #73338

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Conversation

smith
Copy link
Contributor

@smith smith commented Jul 27, 2020

The link was including serviceName from the urlParams so it was linking to the wrong service. Overwrite the service name so the link is correct.

Fixes #72911.

The link was including `serviceName` from the `urlParams` so it was linking to the wrong service. Overwrite the service name so the link is correct.

Fixes elastic#72911.
@smith smith added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 27, 2020
@smith smith requested a review from a team as a code owner July 27, 2020 19:16
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
apm 3.7MB +1.1KB 3.7MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 5a47218 into elastic:master Jul 27, 2020
@smith smith added the v7.10.0 label Jul 27, 2020
kibanamachine pushed a commit that referenced this pull request Jul 27, 2020
The link was including `serviceName` from the `urlParams` so it was linking to the wrong service. Overwrite the service name so the link is correct.

Fixes #72911.
@kibanamachine
Copy link
Contributor

💚 Backport successful

The PR was backported to the following branches:

smith added a commit to smith/kibana that referenced this pull request Jul 27, 2020
The link was including `serviceName` from the `urlParams` so it was linking to the wrong service. Overwrite the service name so the link is correct.

Fixes elastic#72911.
@smith smith deleted the nls/focus-fix branch July 27, 2020 21:44
smith added a commit that referenced this pull request Jul 28, 2020
The link was including `serviceName` from the `urlParams` so it was linking to the wrong service. Overwrite the service name so the link is correct.

Fixes #72911.
smith pushed a commit that referenced this pull request Jul 28, 2020
The link was including `serviceName` from the `urlParams` so it was linking to the wrong service. Overwrite the service name so the link is correct.

Fixes #72911.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 28, 2020
* master: (44 commits)
  [Search] add server logs (elastic#72454)
  [SIEM][Timelines] Updates timeline template callout text (elastic#73334)
  Fix App status  flaky test (elastic#72853)
  [Functional Tests] Increase the timeout when locating the tableview] (elastic#73243)
  Use "Apply_filter_trigger" in dashboard drilldown (elastic#71468)
  fix dashboard index pattern race condition (elastic#72899)
  [Functional Tests] Increase waitTime for timelion to fetch the results (elastic#73255)
  [Functional Tests] Fix flakiness on TSVB chart on switching index patterns test (elastic#73238)
  updates cypress to v4.11.0 (elastic#73327)
  [Metrics UI] Saved views bugs (elastic#72518)
  [Ingest Manager] Convert select agent config step to use combo box (elastic#73172)
  Exclude `version` from package config attributes that are copied, add safeguard to package config bulk create (elastic#73128)
  [Security Solution][ML] Updates siem group name to security (elastic#73218)
  [Security Solution] Show proper icon for termination status of all processes (elastic#73235)
  [Security Solution][Resolver] Show origin node details in panel on load (elastic#73313)
  [Security solution] Threat hunting test coverage improvements (elastic#73276)
  [Security Solution][Exceptions] - Update exception item comments to include id (elastic#73129)
  [Enterprise Search] Error state UI tweaks to account for current Cloud SSO behavior (elastic#73324)
  [dev/build/docker_generator] convert to typescript (elastic#73339)
  [APM] Fix focus map link on service map (elastic#73338)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.9.0 v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Service Maps: Popovers: test 7: 'Focus map' button reloads service map with selected node "focused"
4 participants