Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM][Timelines] Updates timeline template callout text #73334

Merged
merged 3 commits into from
Jul 28, 2020
Merged

[SIEM][Timelines] Updates timeline template callout text #73334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84d4289
updates timeline template callout text
MadameSheema Jul 27, 2020
05ee53f
fixes typo in constant
MadameSheema Jul 27, 2020
dd5e474
Merge branch 'master' into updates-timeline-template-text
elasticmachine Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/public/timelines/components/timeline/header/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ describe('Header', () => {
expect(
wrapper.find('[data-test-subj="timelineImmutableCallOut"]').first().prop('title')
).toEqual(
'This timeline is immutable, therefore not allowed to save it within the security application, though you may continue to use the timeline to search and filter security events'
'This prebuilt timeline template cannot be modified. To make changes, please duplicate this template and make modifications to the duplicate template.'
);
});
});
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/public/timelines/components/timeline/header/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ const TimelineHeaderComponent: React.FC<Props> = ({
{status === TimelineStatus.immutable && (
<EuiCallOut
data-test-subj="timelineImmutableCallOut"
title={i18n.CALL_OUT_IMMUTIABLE}
title={i18n.CALL_OUT_IMMUTABLE}
color="primary"
iconType="alert"
size="s"
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/security_solution/public/timelines/components/timeline/header/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ export const CALL_OUT_UNAUTHORIZED_MSG = i18n.translate(
}
);

export const CALL_OUT_IMMUTIABLE = i18n.translate(
export const CALL_OUT_IMMUTABLE = i18n.translate(
'xpack.securitySolution.timeline.callOut.immutable.message.description',
{
defaultMessage:
'This timeline is immutable, therefore not allowed to save it within the security application, though you may continue to use the timeline to search and filter security events',
'This prebuilt timeline template cannot be modified. To make changes, please duplicate this template and make modifications to the duplicate template.',
}
);