Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solutions] Show popovers inside modals #73264

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Jul 27, 2020

Summary

This PR fixes an issue where popovers, like pagination or filters, inside a modal, are being hidden. With this fix, only draggable popovers are being hidden.

To test it:

  1. Go to Hosts -> All hosts.
  2. Hover over a hostname.
  3. Chose the Show top host.name menu action.
  4. Click the inspect button in the Top N popover.

Expected behavior: The Top N popover is hidden while the inspect modal is displayed.

  1. Open timeline.
  2. Give it a name.
  3. Press the gear button.
  4. Press Add timeline to existing case...
  5. Click the Reporters, Tags and pagination filters

Expected behavior: The popovers should be visible.

Checklist

For maintainers

@cnasikas cnasikas requested review from a team as code owners July 27, 2020 13:09
@cnasikas cnasikas self-assigned this Jul 27, 2020
@cnasikas cnasikas added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:SIEM labels Jul 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review looks good. I did the requested manual tests and both behave as expected. LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +78.0B 7.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with both the provided instructions and against the value lists modal. Modals/popovers look good in both those cases!

@cnasikas cnasikas merged commit 46fb847 into elastic:master Jul 28, 2020
@cnasikas cnasikas deleted the fix_modal_popovers branch July 28, 2020 11:38
cnasikas added a commit to cnasikas/kibana that referenced this pull request Jul 28, 2020
cnasikas added a commit to cnasikas/kibana that referenced this pull request Jul 28, 2020
cnasikas added a commit that referenced this pull request Jul 28, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants