-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solutions] Show popovers inside modals #73264
Conversation
Pinging @elastic/siem (Team:SIEM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review looks good. I did the requested manual tests and both behave as expected. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this with both the provided instructions and against the value lists modal. Modals/popovers look good in both those cases!
Co-authored-by: Elastic Machine <[email protected]>
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
This PR fixes an issue where popovers, like pagination or filters, inside a modal, are being hidden. With this fix, only draggable popovers are being hidden.
To test it:
Show top host.name menu
action.Expected behavior: The Top N popover is hidden while the inspect modal is displayed.
Add timeline to existing case...
Expected behavior: The popovers should be visible.
Checklist
For maintainers