[SIEM] Executes Cypress when there is a change on some Alerts files #73256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadameSheema
added
Team:SIEM
v8.0.0
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
gmmorris
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
LGTM 👍
I think it’s important for us to know if a change in the framework breaks your usage of it, so I'm approving this change in the name of the @elastic/kibana-alerting-services team.
But my fear is that it might force us to fix your usage as part of our PR, and that might be more problematic.
I’m happy to approve for now, and if we find it’s problematic we can revisit :thu:
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Jul 28, 2020
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Jul 28, 2020
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our Cypress tests are only executed when there is a change on:
We have some dependencies with Alerting team. In this PR we are extending the configuration to execute our tests also for: