Apply -snapshot suffix during build task #7317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ``` | ||
|
|
||
| #### Debugging unit tests | ||
|
|
||
| The standard `npm run test` task runs several sub tasks and can take several minutes to complete, making debugging failures pretty painful. In order to ease the pain specialized tasks provide alternate methods for running the tests. | ||
|
|
||
|
|
||
| `npm run test:quick` | ||
| `npm run test:quick` |
There was a problem hiding this comment.
I have no clue why all of these lines had spaces after them, but my editor removed them on save.
The default behavior of the build task is to now apply the -snapshot suffix dynamically rather than us manually hardcoding and managing it within the source code itself. The `--release` flag will drop the -snapshot suffix on a build, which should be used for any release candidate. The default behavior of the build task has also changed to create rpm/deb packages as well. Since we've only confirmed that this works on linux, you can override that behavior by passing `skip-os-packages`. If you do not want to create any zip or tar.gz archives, you can pass `--skip-archives`.
|
This isn't a huge issue, but using more than one option doesn't seem to be working: |
|
^ Looks like it's fixed in grunt 1.0 |
|
LGTM |
|
Yeah, it's really annoying. You need to set all but the last flag explicitly if you're doing more than one: |
elastic-jasper
added a commit
that referenced
this pull request
Jun 15, 2016
--------- **Commit 1:** Apply -snapshot suffix during build task The default behavior of the build task is to now apply the -snapshot suffix dynamically rather than us manually hardcoding and managing it within the source code itself. The `--release` flag will drop the -snapshot suffix on a build, which should be used for any release candidate. The default behavior of the build task has also changed to create rpm/deb packages as well. Since we've only confirmed that this works on linux, you can override that behavior by passing `skip-os-packages`. If you do not want to create any zip or tar.gz archives, you can pass `--skip-archives`. * Original sha: 834f563 * Authored by Court Ewing <[email protected]> on 2016-05-27T20:40:57Z
epixa
added a commit
that referenced
this pull request
Jul 22, 2016
--------- **Commit 1:** Apply -snapshot suffix during build task The default behavior of the build task is to now apply the -snapshot suffix dynamically rather than us manually hardcoding and managing it within the source code itself. The `--release` flag will drop the -snapshot suffix on a build, which should be used for any release candidate. The default behavior of the build task has also changed to create rpm/deb packages as well. Since we've only confirmed that this works on linux, you can override that behavior by passing `skip-os-packages`. If you do not want to create any zip or tar.gz archives, you can pass `--skip-archives`. * Original sha: 834f563 * Authored by Court Ewing <[email protected]> on 2016-05-27T20:40:57Z
epixa
added a commit
that referenced
this pull request
Jul 22, 2016
[backport] PR #7317 to 4.x - Apply -snapshot suffix during build task
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Apply -snapshot suffix during build task Former-commit-id: dbfee59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior of the build task is to now apply the -snapshot
suffix dynamically rather than us manually hardcoding and managing it
within the source code itself. The
--releaseflag will drop the-snapshot suffix on a build, which should be used for any release
candidate.
The default behavior of the build task has also changed to create
rpm/deb packages as well. Since we've only confirmed that this works on
linux, you can override that behavior by passing
skip-os-packages.If you do not want to create any zip or tar.gz archives, you can pass
--skip-archives.Closes #6941