-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/explore underlying data in maps poc #73067
Dev/explore underlying data in maps poc #73067
Conversation
}); | ||
} else { | ||
// Applies filters immediately, without intermediate context menu with multiple possible actions | ||
getUiActions().getAction(ACTION_APPLY_FILTER).execute({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ppisljar, we discussed that we could give this a try and check if it works.
ACTION_APPLY_FILTER
is coming from embeddable plugin and not directly dependant on global filter manager. So seems this approach is OK? What do you think?
01bba57
to
e24313a
Compare
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/embeddable/tooltip_filter_actions·js.maps app embeddable tooltip filter actions should create filters when create filter button is clickedStandard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/embeddable/tooltip_filter_actions·js.maps app embeddable tooltip filter actions should create filters when create filter button is clickedStandard Out
Stack Trace
Build metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
I think we can close this due to #74332 decision |
Summary
Possible way forward with: #73043
This pr enabled
explore underlying data
in map embeddable, for alladdFilters
cases except afterdraw shape
(See: #71445 (comment))There are multiple ways to achieve this described here: #72673
And in this pr this is down by executing action directly
If we decided we want to go forward with this, I can fix function test which doesn't expect popup to appear.
Checklist
Delete any items that are not applicable to this PR.
For maintainers