-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Fixing recognizer wizard create job button #73025
Merged
jgowdyelastic
merged 2 commits into
elastic:master
from
jgowdyelastic:fixing-recognizer-wizard-create-job-button
Jul 24, 2020
Merged
[ML] Fixing recognizer wizard create job button #73025
jgowdyelastic
merged 2 commits into
elastic:master
from
jgowdyelastic:fixing-recognizer-wizard-create-job-button
Jul 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
:ml
bug
Fixes for quality problems that affect the customer experience
Feature:Anomaly Detection
ML anomaly detection
release_note:fix
v7.10.0
v7.9.0
v8.0.0
labels
Jul 23, 2020
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qn895
approved these changes
Jul 23, 2020
LGTM |
alvarezmelissa87
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jul 24, 2020
* [ML] Fixing recognizer wizard create job button * updating translations
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jul 24, 2020
* [ML] Fixing recognizer wizard create job button * updating translations
jgowdyelastic
added a commit
that referenced
this pull request
Jul 24, 2020
jgowdyelastic
added a commit
that referenced
this pull request
Jul 24, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 27, 2020
* master: (111 commits) Remove flaky note from gauge tests (elastic#73240) Convert functional vega tests to ts and unskip tests (elastic#72238) [Graph] Unskip graph tests (elastic#72291) Add default Elasticsearch credentials to docs (elastic#72617) [APM] Read body from indicesStats in upload-telemetry-data (elastic#72732) The directory in the command was missing the /generated directory and would cause all definitions to be regenerated in the wrong place. (elastic#72766) [KP] use new ES client in SO service (elastic#72289) [Security Solution][Exceptions] Prevents value list entries from co-existing with non value list entries (elastic#72995) Return EUI CSS to Shareable Runtime (elastic#72990) Removed useless karma test (elastic#73190) [INGEST_MANAGER] Make package config name blank for endpoint on Package Config create (elastic#73082) [Ingest Manager] Support DEGRADED state in fleet agent event (elastic#73104) [Security Solution][Detections] Change detections breadcrumb title (elastic#73059) [ML] Fixing unnecessary deleting job polling (elastic#73087) [ML] Fixing recognizer wizard create job button (elastic#73025) [Composable template] Preview composite template (elastic#72598) [Uptime] Use manual intervals for ping histogram (elastic#72928) [Security Solution][Endpoint] Task/policy save modal text change, remove duplicate policy details text (elastic#73130) [Maps] fix tile layer attibution text and attribution link validation errors (elastic#73160) skip ingest pipeline api tests ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Anomaly Detection
ML anomaly detection
:ml
release_note:fix
v7.9.0
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with Recognizer wizard create job button.
If creating jobs in the Recognizer wizard and switching off
Start datafeed after save
the button still says "Analysis running"Also the button is not disabled and it's possible to press it multiple times which all call the setup endpoint and cause it to throw errors.
Solution disables the button and retains the
Create job
text, inline with our other wizards.