-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete legacy apm_oss plugin #73016
delete legacy apm_oss plugin #73016
Conversation
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
@elastic/apm-ui following discussion here #71927 (comment), it seems that the remains of the legacy apm_oss plugin were unused and can safely be removed. CI seems to agree with me, but could you confirm that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only use apm_oss
to declare kibana configs. It also looks like they are also defined in:
kibana/src/plugins/apm_oss/server/index.ts
Lines 26 to 33 in b2a473d
enabled: schema.boolean({ defaultValue: true }), | |
transactionIndices: schema.string({ defaultValue: 'apm-*' }), | |
spanIndices: schema.string({ defaultValue: 'apm-*' }), | |
errorIndices: schema.string({ defaultValue: 'apm-*' }), | |
metricsIndices: schema.string({ defaultValue: 'apm-*' }), | |
sourcemapIndices: schema.string({ defaultValue: 'apm-*' }), | |
onboardingIndices: schema.string({ defaultValue: 'apm-*' }), | |
indexPattern: schema.string({ defaultValue: 'apm-*' }), |
So lgtm. Thanks for taking care of this 👍
# Conflicts: # src/legacy/server/kbn_server.d.ts
Summary
Related to #71927
Delete the legacy
apm_oss
plugin.