Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete legacy apm_oss plugin #73016

Merged

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Jul 23, 2020

Summary

Related to #71927

Delete the legacy apm_oss plugin.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet added Feature:Legacy Removal Issues related to removing legacy Kibana release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Jul 23, 2020
@pgayvallet pgayvallet marked this pull request as ready for review July 23, 2020 11:46
@pgayvallet pgayvallet requested a review from a team as a code owner July 23, 2020 11:46
@pgayvallet
Copy link
Contributor Author

@elastic/apm-ui following discussion here #71927 (comment), it seems that the remains of the legacy apm_oss plugin were unused and can safely be removed. CI seems to agree with me, but could you confirm that?

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only use apm_oss to declare kibana configs. It also looks like they are also defined in:

enabled: schema.boolean({ defaultValue: true }),
transactionIndices: schema.string({ defaultValue: 'apm-*' }),
spanIndices: schema.string({ defaultValue: 'apm-*' }),
errorIndices: schema.string({ defaultValue: 'apm-*' }),
metricsIndices: schema.string({ defaultValue: 'apm-*' }),
sourcemapIndices: schema.string({ defaultValue: 'apm-*' }),
onboardingIndices: schema.string({ defaultValue: 'apm-*' }),
indexPattern: schema.string({ defaultValue: 'apm-*' }),

So lgtm. Thanks for taking care of this 👍

@pgayvallet pgayvallet merged commit 49782f9 into elastic:master Jul 23, 2020
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Jul 23, 2020
# Conflicts:
#	src/legacy/server/kbn_server.d.ts
pgayvallet added a commit that referenced this pull request Jul 23, 2020
# Conflicts:
#	src/legacy/server/kbn_server.d.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Legacy Removal Issues related to removing legacy Kibana release_note:skip Skip the PR/issue when compiling release notes v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants