-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[src/dev/build] typescript-ify and convert tests to jest #72525
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
Have some TS issues to figure out... |
1b2d2c9
to
d1c9ed5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a look through the changes, verified the test counts line up in jest, and pulled down the x-pack tar build. If this targets 7.9.0 I want to do a smoke test of all of the builds, I'm okay now if it's 7.9.1.
I'm out of CPU and can run a build EOD , and probably run a million mac updates - or if someone else gives a verbal works for me. Might be able to piece it together earlier, I'll boot the mac up now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - reviewed and manually tested the Linux build.
import { ToolingLog } from '@kbn/dev-utils'; | ||
|
||
import { Config, createRunner } from './lib'; | ||
import * as Tasks from './tasks'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/uptime·ts.uptime settings pageStandard Out
Stack Trace
Build metrics
History
To update your PR or re-run it, just comment with: |
Co-authored-by: spalger <[email protected]>
Co-authored-by: spalger <[email protected]> # Conflicts: # src/dev/build/build_distributables.js
… (#73108) Co-authored-by: spalger <[email protected]> Co-authored-by: spalger <[email protected]>
…3110) Co-authored-by: spalger <[email protected]> # Conflicts: # src/dev/build/build_distributables.js
Before working on #71881 I'd like to "pay back" some debt and finish converting the
src/dev/build
module to TypeScript and Jest. The functionality is exactly the same, we just have a little less untyped code and fewer mocha tests.Related: #72496