[Security Solution][Exceptions] - Update UI exceptions builder nested logic #72490

yctercero · 2020-07-20T17:23:01Z

Summary

🥁 This PR is meant to update the exception builder logic to handle nested fields. If you're unfamiliar with nested fields, you can read up more on it here and here. It also does a bit of cleanup, so though it may look like a lot of changes, parts of it were just moving some things around.

Breaks the exceptions/helpers.tsx file into separate helper files under the corresponding components (builder or viewer) where there wasn't any overlap
Adds onClick to add/edit exceptions modal mask overlay so that user does not need to refresh page if modal hits an issue
Updates the builder_button_options.tsx to now expose the Add nested field to UI
Fixes bug that does not allow user to use delete key in field input
Updates logic to be as follows:
- Add nested field is available at all times - it can be disabled if need be by the consumer of the exceptions builder
  - If a user clicks Add nested field, a new empty entry is shown that limits the fields to only nested types that match the parent and Or is disabled
  - When the user selects a field, 2 new entries appear, one is the parent, the other the selected nested field
  - If user selects Add, another entry, still under the nested parent is added
  - If user is finished adding to their nested field, they can click Add non nested field and it returns them to the normal flow
  - User can delete a single nested entry
    - If it is the only nested entry, the entire nested parent and child is removed
    - Clicking Delete next to the parent entry, deletes the entire nested entry and children
- If a user is left with one entry in the builder and they select Delete, an empty entry, similar to the one shown on init is displayed

Note: Double checked with @marrasherrier on the design. The initial designs limited the user to adding one nested field as the last item. This allows a user to add multiple nested fields and non-nested fields.

Samples 🤤

Close modal when overlay mask clicked

Allow user to delete field selection with delete key

If user deletes last item, goest back to empty default

Adding a nested entry

Deleting nested entry

Sample `and`, `or`, `nested`

To Do

Cleanup builder/entry_item.tsx
Add better logic for when user selects Add nested --> then selects Add non nested without having selected any nested field

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

…ll checking signals index for closing alerts functionality

apmmachine · 2020-07-21T12:41:13Z

💚 Build Succeeded

Expand to view the summary

Build stats

Build Cause: [Pull request #72490 updated]
Start Time: 2020-07-21T12:36:21.286+0000
Duration: 5 min 49 sec

yctercero · 2020-07-22T01:52:54Z

x-pack/plugins/security_solution/public/common/components/exceptions/helpers.tsx

 */
-export const getFormattedEntries = (entries: BuilderEntry[]): FormattedEntry[] => {


These big chunks that appear as removed were just moved into builder/helper.ts since they weren't shared utils, just applied to the builder. Was trying to cleanup as this file is getting large.

yctercero · 2020-07-22T02:24:24Z

...ins/security_solution/public/common/components/exceptions/builder/builder_exception_item.tsx

@@ -22,14 +23,25 @@ const MyFirstRowContainer = styled(EuiFlexItem)`
  padding-top: 20px;
 `;

+const MyBeautifulLine = styled(EuiFlexItem)`


Happy to remain, my creativity was running low...

elasticmachine · 2020-07-22T03:16:40Z

Pinging @elastic/siem (Team:SIEM)

yctercero · 2020-07-22T04:29:12Z

x-pack/plugins/security_solution/public/common/components/exceptions/builder/entry_item.tsx

-        },
-        entryIndex
-      );
+      if (entry.nested === 'parent') {


Want to follow up moving all this logic out to easily testable helpers.

FrankHassanabad

LGTM! Wow, you really did us all so many favors this release with all these features and nested.

kibanamachine · 2020-07-22T22:20:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 1b4fbac

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	7.3MB	+24.7KB	7.3MB

History

💔 Build #63743 failed 456b590
💔 Build #63718 failed 06864b7
💚 Build #63505 succeeded 2f92856
💔 Build #63502 failed f1e577b
💔 Build #63498 failed 8b1daca

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

… logic (elastic#72490) ## Summary This PR is meant to update the exception builder logic to handle nested fields. If you're unfamiliar with nested fields, you can read up more on it [here](https://www.elastic.co/guide/en/elasticsearch/reference/current/nested.html) and [here](elastic#44554). It also does a bit of cleanup, so though it may look like a lot of changes, parts of it were just moving some things around.

… logic (#72490) (#72982) ## Summary This PR is meant to update the exception builder logic to handle nested fields. If you're unfamiliar with nested fields, you can read up more on it [here](https://www.elastic.co/guide/en/elasticsearch/reference/current/nested.html) and [here](#44554). It also does a bit of cleanup, so though it may look like a lot of changes, parts of it were just moving some things around.

… logic (#72490) (#72983) ## Summary This PR is meant to update the exception builder logic to handle nested fields. If you're unfamiliar with nested fields, you can read up more on it [here](https://www.elastic.co/guide/en/elasticsearch/reference/current/nested.html) and [here](#44554). It also does a bit of cleanup, so though it may look like a lot of changes, parts of it were just moving some things around.

* master: (35 commits) Migrated karma tests to jest (elastic#72649) Migrate status page app to core (elastic#72017) Failing test: Jest Tests.src/plugins/vis_type_vega/public (elastic#71834) Fix Firefox TSVB flaky test with switch index patterns (elastic#72882) [ML] Fixing link to index management from file data visualizer (elastic#72863) test: 💍 add test for sub-expression variables (elastic#71644) fix bug (elastic#72809) [keystore] use get_keystore in server cli (elastic#72954) Show step number instead of incomplete step. (elastic#72866) Fix bug where user can't add an exception when "close alert" is checked (elastic#72919) [Monitoring] Fix issues displaying alerts (elastic#72891) [Ingest Manager] Add more Fleet concurrency tests elastic#71744 (elastic#72338) [Security Solution][Exceptions] - Update UI exceptions builder nested logic (elastic#72490) disable renovate masterIssue [ML] API integration tests for UPDATE data frame analytics endpoint (elastic#72710) [Uptime] Fix accessibility issue in Uptime app nav links (elastic#72926) [Maps] fix removing global filter from layer can cause app to start thrashing (elastic#72763) [Maps] fix blended layer aggregation error when using composite aggregation (elastic#72759) fix unexpected arguments to unload command Limits the upload size of lists to 9 meg size (elastic#72898) ...

elasticmachine · 2021-09-23T14:29:46Z

Pinging @elastic/security-solution (Team: SecuritySolution)

yctercero added 15 commits July 17, 2020 12:12

making estypes and subtype available in indexPatterns

952a105

updating graphql types

4448734

Merge branch 'master' of github.com:yctercero/kibana into index_es_types

c56a96d

update source graphql type to match expected

f059d70

cleanup

42de990

tests

ebcb6d3

cleanup

2861cfa

updated tests, reverted changes to modals, to make sure they were sti…

760ed31

…ll checking signals index for closing alerts functionality

Merge branch 'master' of github.com:yctercero/kibana into index_es_types

548ead4

wip - adding nested to builder

41ea682

Merge branch 'master' of github.com:yctercero/kibana into builder_nested

a813031

wip - updating unit tests

67829d3

Merge branch 'master' of github.com:yctercero/kibana into builder_nested

4f00202

updated unit tests

37cebb5

cleanup types

767d083

yctercero added 2 commits July 21, 2020 21:21

Merge branch 'master' of github.com:yctercero/kibana into builder_nested

b62375c

cleanup

8b1daca

yctercero commented Jul 22, 2020

View reviewed changes

updated types

f1e577b

yctercero commented Jul 22, 2020

View reviewed changes

yctercero self-assigned this Jul 22, 2020

yctercero added release_note:enhancement Team:SIEM v7.10.0 v7.9.0 v8.0.0 labels Jul 22, 2020

update unit test

2f92856

yctercero marked this pull request as ready for review July 22, 2020 03:16

yctercero requested a review from a team as a code owner July 22, 2020 03:16

yctercero commented Jul 22, 2020

View reviewed changes

yctercero added 2 commits July 22, 2020 14:42

cleanup, cleanup!

bf91b6f

Merge branch 'master' of github.com:yctercero/kibana into builder_nested

06864b7

FrankHassanabad approved these changes Jul 22, 2020

View reviewed changes

yctercero added 2 commits July 22, 2020 15:49

minor fix

456b590

Merge branch 'master' of github.com:yctercero/kibana into builder_nested

1b4fbac

yctercero merged commit f7a1679 into elastic:master Jul 22, 2020

yctercero mentioned this pull request Jul 22, 2020

[7.x] [Security Solution][Exceptions] - Update UI exceptions builder nested logic (#72490) #72982

Merged

yctercero mentioned this pull request Jul 22, 2020

[7.9] [Security Solution][Exceptions] - Update UI exceptions builder nested logic (#72490) #72983

Merged

yctercero deleted the builder_nested branch October 14, 2020 12:00

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Exceptions] - Update UI exceptions builder nested logic #72490

[Security Solution][Exceptions] - Update UI exceptions builder nested logic #72490

yctercero commented Jul 20, 2020 •

edited

Loading

apmmachine commented Jul 21, 2020

Build stats

yctercero Jul 22, 2020

yctercero Jul 22, 2020

elasticmachine commented Jul 22, 2020

yctercero Jul 22, 2020

FrankHassanabad left a comment

kibanamachine commented Jul 22, 2020

elasticmachine commented Sep 23, 2021

		*/
		export const getFormattedEntries = (entries: BuilderEntry[]): FormattedEntry[] => {

[Security Solution][Exceptions] - Update UI exceptions builder nested logic #72490

[Security Solution][Exceptions] - Update UI exceptions builder nested logic #72490

Conversation

yctercero commented Jul 20, 2020 • edited Loading

Summary

Samples 🤤

Close modal when overlay mask clicked

Allow user to delete field selection with delete key

If user deletes last item, goest back to empty default

Adding a nested entry

Deleting nested entry

Sample and, or, nested

To Do

Checklist

apmmachine commented Jul 21, 2020

💚 Build Succeeded

Build stats

yctercero Jul 22, 2020

Choose a reason for hiding this comment

yctercero Jul 22, 2020

Choose a reason for hiding this comment

elasticmachine commented Jul 22, 2020

yctercero Jul 22, 2020

Choose a reason for hiding this comment

FrankHassanabad left a comment

Choose a reason for hiding this comment

kibanamachine commented Jul 22, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

elasticmachine commented Sep 23, 2021

yctercero commented Jul 20, 2020 •

edited

Loading

Sample `and`, `or`, `nested`