Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA][Code Coverage] Fixup Team Assignment #72467

Merged
merged 3 commits into from
Jul 21, 2020
Merged

[QA][Code Coverage] Fixup Team Assignment #72467

merged 3 commits into from
Jul 21, 2020

Conversation

wayneseymour
Copy link
Member

Resolves #72401

@wayneseymour wayneseymour added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage backport:skip This commit does not require backporting labels Jul 20, 2020
@wayneseymour wayneseymour self-assigned this Jul 20, 2020
@wayneseymour
Copy link
Member Author

Testing: https://kibana-ci.elastic.co/job/elastic+kibana+qa-research/47/

@wayneseymour
Copy link
Member Author

Testing https://kibana-ci.elastic.co/job/elastic+kibana+qa-research/48/

@wayneseymour wayneseymour force-pushed the fixup-team-assignment branch from ab1893e to e20a9bf Compare July 20, 2020 20:41
@wayneseymour
Copy link
Member Author

Testing https://kibana-ci.elastic.co/job/elastic+kibana+qa-research/49/

@wayneseymour
Copy link
Member Author

Testing https://kibana-ci.elastic.co/job/elastic+kibana+qa-research/50/

@wayneseymour wayneseymour marked this pull request as ready for review July 20, 2020 20:52
@wayneseymour wayneseymour requested a review from a team as a code owner July 20, 2020 20:52
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wayneseymour
Copy link
Member Author

Testing on Code Coverage Job: https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/929/

dmlemeshko
dmlemeshko reviewed Jul 21, 2020
View reviewed changes
src/dev/code_coverage/ingest_coverage/team_assignment/index.js

const { path } = flags;

fetch(path).fold(logLeft, updateAndLog);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen now if getContents fails?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logLeft() should happen.

dmlemeshko
dmlemeshko approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

I wonder what was the reason to fail and what are the cases when it may go wrong again?

@wayneseymour wayneseymour merged commit 98fabd4 into master Jul 21, 2020
@wayneseymour wayneseymour deleted the fixup-team-assignment branch July 21, 2020 15:58
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 21, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
53aa8e9 
* master:
  [Security Solution][Timeline] Add Empty view to the Timelines page (elastic#72576)
  [Security Solution][Resolver] Show process detail panel when clicking a process node (elastic#72563)
  Move manifest packageConfig mocks into security_solution plugin (elastic#72527)
  [QA][Code Coverage] Fixup Team Assignment (elastic#72467)
  [docs] remove references to tile map visualization in supported aggregations (elastic#72493)
  [ci][apm-ui] fix argument name for disabling pr comments (elastic#72633)
  Only check that the event ids are the same in arrays (elastic#72624)
  Add doc titles to ES UI apps (elastic#71045)
  Add Upgrade Assistant API integration test to ensure the reindex operation saved object can handle immense error messages (elastic#72347)
  [APM] Disable flaky rum e2e’s (elastic#72614)
  Applying tiny fix from 72532 to main branch (elastic#72533)
  [APM] Update script with new roles/users (elastic#72599)
  [Security Solution] Add margin (elastic#72542)
  Migrated fixed_scroll karma tests to jest (elastic#72258)
  [ML] Handling data recognizer saved object errors (elastic#72447)
  [Monitoring] Fix the messaging around needing TLS enabled (elastic#72310)
  [Task Manager] Batches the update operations in Task Manager  (elastic#71470)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 22, 2020
@gmmorris
Merge branch 'alerting/consumer-based-rbac' into alerting/management-…
fb1d793 
…feature-privileges

* alerting/consumer-based-rbac:
  [Security Solution][Timeline] Add Empty view to the Timelines page (elastic#72576)
  [Security Solution][Resolver] Show process detail panel when clicking a process node (elastic#72563)
  renamed variable to make it clear the SO client is unsecured
  Move manifest packageConfig mocks into security_solution plugin (elastic#72527)
  [QA][Code Coverage] Fixup Team Assignment (elastic#72467)
  [docs] remove references to tile map visualization in supported aggregations (elastic#72493)
  [ci][apm-ui] fix argument name for disabling pr comments (elastic#72633)
  Only check that the event ids are the same in arrays (elastic#72624)
  includes hidden params type in SO client
  Add doc titles to ES UI apps (elastic#71045)
  Add Upgrade Assistant API integration test to ensure the reindex operation saved object can handle immense error messages (elastic#72347)
  [APM] Disable flaky rum e2e’s (elastic#72614)
  Applying tiny fix from 72532 to main branch (elastic#72533)
  [APM] Update script with new roles/users (elastic#72599)
  [Security Solution] Add margin (elastic#72542)
  Migrated fixed_scroll karma tests to jest (elastic#72258)
  [ML] Handling data recognizer saved object errors (elastic#72447)
  [Monitoring] Fix the messaging around needing TLS enabled (elastic#72310)
  [Task Manager] Batches the update operations in Task Manager  (elastic#71470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@LeeDr LeeDr Awaiting requested review from LeeDr

@marius-dr marius-dr Awaiting requested review from marius-dr

Assignees

@wayneseymour wayneseymour

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code coverage: process breaks while running team assignment script
3 participants
@wayneseymour @kibanamachine @dmlemeshko