Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] re-enable tests. retry on fail (#72061) #72287

Merged
merged 1 commit into from
Jul 17, 2020
Merged

[7.x] re-enable tests. retry on fail (#72061) #72287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...nalytics/pages/analytics_creation/components/configuration_step/analysis_fields_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ export const AnalysisFieldsTable: FC<{
return (
<Fragment>
<EuiFormRow
data-test-subj="mlAnalyticsCreateJobWizardIncludesTable"
label={i18n.translate('xpack.ml.dataframe.analytics.create.includedFieldsLabel', {
defaultMessage: 'Included fields',
})}
Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/ml/data_frame_analytics/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ loadTestFile }: FtrProviderContext) {
// flaky tests
describe.skip('data frame analytics', function () {
describe('data frame analytics', function () {
this.tags(['mlqa', 'skipFirefox']);

loadTestFile(require.resolve('./outlier_detection_creation'));
Expand Down
6 changes: 5 additions & 1 deletion x-pack/test/functional/services/ml/data_frame_analytics_creation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,11 @@ export function MachineLearningDataFrameAnalyticsCreationProvider(
},

async assertIncludeFieldsSelectionExists() {
await testSubjects.existOrFail('mlAnalyticsCreateJobWizardIncludesSelect', { timeout: 5000 });
await testSubjects.existOrFail('mlAnalyticsCreateJobWizardIncludesTable', { timeout: 8000 });

await retry.tryForTime(8000, async () => {
await testSubjects.existOrFail('mlAnalyticsCreateJobWizardIncludesSelect');
});
},

// async assertIncludedFieldsSelection(expectedSelection: string[]) {
Expand Down