Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'return' in console test #7219

Merged
merged 5 commits into from
May 20, 2016

Conversation

LeeDr
Copy link

@LeeDr LeeDr commented May 16, 2016

I don't know if I have a problem in the most recently added console tests, and/or there's something about the change to babel 6 that isn't correct in these tests but at the moment the last tryForTime runs on after the last console test has passed. I think I may need a final return in the tests.

>> PASS: firefox on any platform - kibana - console app - console app - should show the default request (81245ms)
>> PASS: firefox on any platform - kibana - console app - console app - default request response should contain .kibana (0ms)
>> 0/2 tests failed
>> 0/2 tests failed
>> 0/82 tests failed
>> 0/82 tests failed
16:57:18.154: tryForTime failure: [GET http://localhost:4444/wd/hub/session/c206e9f1-f5f0-4f57-bf89-1cb70f4e060f/element/818/text] The FirefoxDriver cannot be used after quit() was called.
Build info: version: '2.53.0', revision: '35ae25b', time: '2016-03-15 17:00:58'
System info: host: 'slave12.build.ci.hetz.es.io', ip: '5.9.121.212', os.name: 'Linux', os.arch: 'amd64', os.version: '3.13.0-24-generic', java.version: '1.8.0_72'
Driver info: driver.version: RemoteWebDriver
16:57:18.664: tryForTime failure: [POST http://localhost:4444/wd/hub/session/c206e9f1-f5f0-4f57-bf89-1cb70f4e060f/element / {"using":"css selector","value":"#output > div.ace_scroller > div"}] Build info: version: '2.53.0', revision: '35ae25b', time: '2016-03-15 17:00:58'
System info: host: 'slave12.build.ci.hetz.es.io', ip: '5.9.121.212', os.name: 'Linux', os.arch: 'amd64', os.version: '3.13.0-24-generic', java.version: '1.8.0_72'
Driver info: driver.version: unknown
16:57:19.178: tryForTime failure: [POST http://localhost:4444/wd/hub/session/c206e9f1-f5f0-4f57-bf89-1cb70f4e060f/element / {"using":"css selector","value":"#output > div.ace_scroller > div"}] Build info: version: '2.53.0', revision: '35ae25b', time: '2016-03-15 17:00:58'
System info: host: 'slave12.build.ci.hetz.es.io', ip: '5.9.121.212', os.name: 'Linux', os.arch: 'amd64', os.version: '3.13.0-24-generic', java.version: '1.8.0_72'
Driver info: driver.version: unknown
16:57:19.694: tryForTime failure: [POST http://localhost:4444/wd/hub/session/c206e9f1-f5f0-4f57-bf89-1cb70f4e060f/element / {"using":"css selector","value":"#output > div.ace_scroller > div"}] Build info: version: '2.53.0', revision: '35ae25b', time: '2016-03-15 17:00:58'
System info: host: 'slave12.build.ci.hetz.es.io', ip: '5.9.121.212', os.name: 'Linux', os.arch: 'amd64', os.version: '3.13.0-24-generic', java.version: '1.8.0_72'
Driver info: driver.version: unknown

@LeeDr LeeDr added bug Fixes for quality problems that affect the customer experience test labels May 16, 2016
@LeeDr
Copy link
Author

LeeDr commented May 20, 2016

jenkins, test it

@LeeDr
Copy link
Author

LeeDr commented May 20, 2016

This change did fix the problem of the tryForTiem running on after the tests completed;

>> 0/82 tests failed

Running "esvm_shutdown:ui" (esvm_shutdown) task

@bevacqua
Copy link
Contributor

LGTM

@LeeDr LeeDr changed the title Test to see if returning from the expects resolves the tryForTime's c… Add missing 'return' in console test May 20, 2016
@LeeDr LeeDr merged commit 9a1caaa into elastic:master May 20, 2016
@LeeDr LeeDr deleted the returnExpectConsoleTests branch May 20, 2016 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience review test v5.0.0-alpha3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants