Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Timeline] Fix value for process.hash.sha256 draggable #72142

Merged
merged 1 commit into from
Jul 17, 2020
Merged

[Security Solution][Timeline] Fix value for process.hash.sha256 draggable #72142

merged 1 commit into from
Jul 17, 2020

Conversation

patrykkopycinski
Copy link
Contributor

Summary

Fixes value passed for process.has.sha256 draggable that caused the timeline to be unresponsive.

Checklist

@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience release_note:fix Team:SIEM v8.0.0 v7.9.0 v7.8.2 labels Jul 16, 2020
@patrykkopycinski patrykkopycinski requested a review from XavierM July 16, 2020 19:27
@patrykkopycinski patrykkopycinski requested review from a team as code owners July 16, 2020 19:27
@patrykkopycinski patrykkopycinski self-assigned this Jul 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@patrykkopycinski patrykkopycinski changed the title Fix value for process.hash.sha256 draggable [Security Solution][Timeline] Fix value for process.hash.sha256 draggable Jul 16, 2020
XavierM
XavierM approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, THis is the best test ever!!!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +3.0B 7.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 6164037 into elastic:master Jul 17, 2020
@patrykkopycinski patrykkopycinski deleted the fix/process-hash256-draggable branch July 17, 2020 07:14
@patrykkopycinski patrykkopycinski mentioned this pull request Jul 17, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jul 17, 2020
@patrykkopycinski
Fix value for process.hash.sha256 draggable (elastic#72142)
8300753
@patrykkopycinski patrykkopycinski mentioned this pull request Jul 17, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jul 17, 2020
@patrykkopycinski
Fix value for process.hash.sha256 draggable (elastic#72142)
b330290
@patrykkopycinski patrykkopycinski mentioned this pull request Jul 17, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jul 17, 2020
@patrykkopycinski
Fix value for process.hash.sha256 draggable (elastic#72142)
1c6dcdf 
# Conflicts:
#	x-pack/plugins/security_solution/public/timelines/components/timeline/body/renderers/system/generic_file_details.test.tsx
#	x-pack/plugins/security_solution/public/timelines/components/timeline/body/renderers/system/generic_file_details.tsx
patrykkopycinski added a commit that referenced this pull request Jul 17, 2020
@patrykkopycinski
Fix value for process.hash.sha256 draggable (#72142) (#72230)
c8930b7
patrykkopycinski added a commit that referenced this pull request Jul 17, 2020
@patrykkopycinski
Fix value for process.hash.sha256 draggable (#72142) (#72229)
d7022a1
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
@gmmorris
Merge branch 'master' into task-manager/batch-update-delete
edb3f1e 
* master: (214 commits)
  replacing hard coded links for ela.st (elastic#72240)
  skip flaky suite (elastic#60865)
  chore(NA): teardown dynamic dll plugin (elastic#72096)
  Register navLink actions for declared applications (elastic#72109)
  Fix value for process.hash.sha256 draggable (elastic#72142)
  Call setupIngest before fleet_install tests (elastic#72214)
  [Security Solution][Detections] Better toast errors (elastic#72205)
  skip flaky suite (elastic#64696)
  [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137)
  [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990)
  [baseline/capture] use high-memory nodes with ramDisks (elastic#71894)
  skip flaky suite (elastic#77207)
  [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946)
  using test_user with minimum privs (elastic#71988)
  Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924)
  [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921)
  [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125)
  [Visualizations] Pass 'aggs' parameter to custom request handlers (elastic#71423)
  [Monitoring] Out of the box alert tweaks (elastic#71942)
  [ML] Fix datafeed start time is incorrect when the job has trailing empty buckets (elastic#71976)
  ...
patrykkopycinski added a commit that referenced this pull request Jul 17, 2020
@patrykkopycinski @elasticmachine
[7.8] Fix value for process.hash.sha256 draggable (#72142) (#72232)
ac93f61 
* Fix value for process.hash.sha256 draggable (#72142)

# Conflicts:
#	x-pack/plugins/security_solution/public/timelines/components/timeline/body/renderers/system/generic_file_details.test.tsx
#	x-pack/plugins/security_solution/public/timelines/components/timeline/body/renderers/system/generic_file_details.tsx

* Update generic_file_details.test.tsx

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
cbee849 
* master: (55 commits)
  updates 'External alerts' tab text (elastic#72237)
  [Security Solution][Case] Fix connector's dropdown with conflicting requests (elastic#72037)
  replacing hard coded links for ela.st (elastic#72240)
  skip flaky suite (elastic#60865)
  chore(NA): teardown dynamic dll plugin (elastic#72096)
  Register navLink actions for declared applications (elastic#72109)
  Fix value for process.hash.sha256 draggable (elastic#72142)
  Call setupIngest before fleet_install tests (elastic#72214)
  [Security Solution][Detections] Better toast errors (elastic#72205)
  skip flaky suite (elastic#64696)
  [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137)
  [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990)
  [baseline/capture] use high-memory nodes with ramDisks (elastic#71894)
  skip flaky suite (elastic#77207)
  [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946)
  using test_user with minimum privs (elastic#71988)
  Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924)
  [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921)
  [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125)
  [Visualizations] Pass 'aggs' parameter to custom request handlers (elastic#71423)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
@gmmorris
Merge branch 'alerting/consumer-based-rbac' into alerting/management-…
fead80a 
…feature-privileges

* alerting/consumer-based-rbac: (56 commits)
  take into account which features available in the active space
  updates 'External alerts' tab text (elastic#72237)
  [Security Solution][Case] Fix connector's dropdown with conflicting requests (elastic#72037)
  replacing hard coded links for ela.st (elastic#72240)
  skip flaky suite (elastic#60865)
  chore(NA): teardown dynamic dll plugin (elastic#72096)
  Register navLink actions for declared applications (elastic#72109)
  Fix value for process.hash.sha256 draggable (elastic#72142)
  Call setupIngest before fleet_install tests (elastic#72214)
  [Security Solution][Detections] Better toast errors (elastic#72205)
  skip flaky suite (elastic#64696)
  [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137)
  [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990)
  [baseline/capture] use high-memory nodes with ramDisks (elastic#71894)
  skip flaky suite (elastic#77207)
  [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946)
  using test_user with minimum privs (elastic#71988)
  Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924)
  [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921)
  [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.2 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrykkopycinski @elasticmachine @kibanamachine @XavierM @MindyRS