-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] DF Analytics: re-enable functional tests #72061
Merged
alvarezmelissa87
merged 1 commit into
elastic:master
from
alvarezmelissa87:ml-dfanalytics-functional-tests-fix
Jul 17, 2020
Merged
[ML] DF Analytics: re-enable functional tests #72061
alvarezmelissa87
merged 1 commit into
elastic:master
from
alvarezmelissa87:ml-dfanalytics-functional-tests-fix
Jul 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
:ml
release_note:skip
Skip the PR/issue when compiling release notes
Feature:Data Frame Analytics
ML data frame analytics features
v7.9.0
labels
Jul 16, 2020
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pheyos
approved these changes
Jul 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jul 17, 2020
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jul 17, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 17, 2020
* master: [ML] Remove DragSelect event handlers and selectors on the swim lane unmount (elastic#72250) Add a few asciidoc readmes (elastic#72082) re-enable tests. retry on fail (elastic#72061) updates advanced settings text (elastic#72249) [ML] Fix HTML named characters encoding (elastic#72060) Bump @elastic/elasticsearch to v7.9.0-rc1 (elastic#72231) Observability landing page title (elastic#72088) [QA][Code Coverage] Drop flaky integration tests (elastic#72089) [Ingest Manager] Fix failing test conflict error (elastic#72149) [Logs UI] Fix display of dataset values in anomaly and category example rows (elastic#71693) [SECURITY] Bug truncation on timeline (elastic#72221) skip flaky suite (elastic#72146)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 17, 2020
…feature-privileges * alerting/consumer-based-rbac: corrected consumer on enable operation [ML] Remove DragSelect event handlers and selectors on the swim lane unmount (elastic#72250) Add a few asciidoc readmes (elastic#72082) re-enable tests. retry on fail (elastic#72061) updates advanced settings text (elastic#72249) [ML] Fix HTML named characters encoding (elastic#72060) Bump @elastic/elasticsearch to v7.9.0-rc1 (elastic#72231) Observability landing page title (elastic#72088) [QA][Code Coverage] Drop flaky integration tests (elastic#72089) [Ingest Manager] Fix failing test conflict error (elastic#72149) [Logs UI] Fix display of dataset values in anomaly and category example rows (elastic#71693) [SECURITY] Bug truncation on timeline (elastic#72221) skip flaky suite (elastic#72146)
alvarezmelissa87
added a commit
that referenced
this pull request
Jul 17, 2020
alvarezmelissa87
added a commit
that referenced
this pull request
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Data Frame Analytics
ML data frame analytics features
:ml
release_note:skip
Skip the PR/issue when compiling release notes
v7.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-enables DF Analytics functional tests and updates a check to retry on fail as the element it is looking for re-renders after an API endpoint hit so sometimes is not on the page the first time the check happens.
This was run through the flaky test runner 100 times with no failures
Checklist
Delete any items that are not applicable to this PR.