Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security][Detections] Unskip failing modal tests #71969

Merged
merged 2 commits into from
Jul 16, 2020
Merged

[Security][Detections] Unskip failing modal tests #71969

merged 2 commits into from
Jul 16, 2020

Commits on Jul 15, 2020

  1. Revert "Skip jest tests that timeout waiting for react" 

    This reverts commit dd9b0b3.
    @rylnd
    rylnd committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    581257b View commit details
    Browse the repository at this point in the history

  2. Unmount async effectful components instead of waiting for them 

    A previous commit introduced waitForUpdates as a solution to the
warnings introduced by enzymejs/enzyme#2073:
by waiting for the effects to complete we avoid the warning.

However, waiting for the effects to complete could occasionally be very
costly, especially on an overtasked CI machine, and I've been seeing
these tests fail on occasion due to timeouts.

Since a warning message is preferable to a false negative, I'm removing
waitForUpdates and allowing the warnings to occur, as this should be
fixed on a subsequent update of enzyme/react-adapter.

I've also fixed warnings in a few particularly problematic/noisy tests
by simply unmounting the component at the end of the test (this does
not work in an afterEach).
    @rylnd
    rylnd committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    b11f980 View commit details
    Browse the repository at this point in the history