Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[esArchiver] automatically retry if alias creation fails #71910

Merged

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jul 15, 2020

Fixes #71043
Fixes #71842
Fixes #71396
Fixes #71397
Fixes #71401
Fixes #65605

We've seen a number of issues caused by ES complaining that the .kibana index exists when trying to create the kibana index. It seems this just requires that we retry the index creation, potentially after deleting existing .kibana indexes again. We've done this for a while with standard index creation, but we haven't handled similar alias conflict errors, so this change is expanding that logic to also retry when aliases conflict with existing indices/aliases.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.0 labels Jul 15, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

miscellaneous assets size

id value diff baseline
upgradeAssistant 22.6KB +1.0B 22.6KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger marked this pull request as ready for review July 15, 2020 20:01
@spalger spalger requested a review from a team as a code owner July 15, 2020 20:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger merged commit 7b2b3d8 into elastic:master Jul 16, 2020
spalger added a commit to spalger/kibana that referenced this pull request Jul 16, 2020
* [esArchiver] automatically retry if alias creation fails

* print aliases to a string when logging

Co-authored-by: spalger <[email protected]>
spalger added a commit to spalger/kibana that referenced this pull request Jul 16, 2020
* [esArchiver] automatically retry if alias creation fails

* print aliases to a string when logging

Co-authored-by: spalger <[email protected]>
spalger added a commit that referenced this pull request Jul 16, 2020
…2002)

* [esArchiver] automatically retry if alias creation fails

* print aliases to a string when logging

Co-authored-by: spalger <[email protected]>

Co-authored-by: spalger <[email protected]>
spalger added a commit that referenced this pull request Jul 16, 2020
…2001)

* [esArchiver] automatically retry if alias creation fails

* print aliases to a string when logging

Co-authored-by: spalger <[email protected]>

Co-authored-by: spalger <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 16, 2020
* master: (37 commits)
  [Lens] Handle failing existence check (elastic#70718)
  [Security Solution]Fix in-app links and popup window text (elastic#71403)
  [esArchiver] automatically retry if alias creation fails (elastic#71910)
  Move data stream index pattern creation test to xpack (elastic#71511)
  [Maps] Improve language for mvt card (elastic#71947)
  [Security][Detections] Unskip failing modal tests (elastic#71969)
  skip flaky suite (elastic#71987)
  skip flaky suite (elastic#71979)
  [Security Solution] [Detections] Revert "[Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768)" (elastic#71956)
  rename ilm policy to remove -default (elastic#71952)
  Adjust ordering of Management category apps to make Ingest Manager higher (elastic#71948)
  skip flaky suite (elastic#71971)
  skip flaky suite (elastic#71951)
  [kbn/optimizer] ignore compressed files when reporting stats (elastic#71940)
  skip flaky suite (elastic#71867)
  [ML] Fix new job with must_not saved search (elastic#71831)
  [Resolver] Fix bug where process detail panel doesn't show up (elastic#71754)
  Cleanup (elastic#71849)
  [Resolver] aria-level and aria-flowto support enhancements (elastic#71887)
  skip flaky suite (elastic#71304)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 16, 2020
…feature-privileges

* alerting/consumer-based-rbac: (491 commits)
  [Lens] Handle failing existence check (elastic#70718)
  [Security Solution]Fix in-app links and popup window text (elastic#71403)
  [esArchiver] automatically retry if alias creation fails (elastic#71910)
  Move data stream index pattern creation test to xpack (elastic#71511)
  [Maps] Improve language for mvt card (elastic#71947)
  [Security][Detections] Unskip failing modal tests (elastic#71969)
  skip flaky suite (elastic#71987)
  skip flaky suite (elastic#71979)
  [Security Solution] [Detections] Revert "[Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768)" (elastic#71956)
  rename ilm policy to remove -default (elastic#71952)
  Adjust ordering of Management category apps to make Ingest Manager higher (elastic#71948)
  skip flaky suite (elastic#71971)
  skip flaky suite (elastic#71951)
  [kbn/optimizer] ignore compressed files when reporting stats (elastic#71940)
  skip flaky suite (elastic#71867)
  [ML] Fix new job with must_not saved search (elastic#71831)
  [Resolver] Fix bug where process detail panel doesn't show up (elastic#71754)
  Cleanup (elastic#71849)
  [Resolver] aria-level and aria-flowto support enhancements (elastic#71887)
  skip flaky suite (elastic#71304)
  ...
@spalger spalger added the v7.8.1 label Jul 17, 2020
spalger added a commit to spalger/kibana that referenced this pull request Jul 17, 2020
* [esArchiver] automatically retry if alias creation fails

* print aliases to a string when logging

Co-authored-by: spalger <[email protected]>
spalger added a commit that referenced this pull request Jul 18, 2020
… and [esArchiver] actually re-delete the .kibana index if we lose recreate race (#72354) (#72365)

Co-authored-by: spalger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Functional Testing release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.8.1 v7.9.0 v7.10.0 v8.0.0
Projects
None yet
5 participants