Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability] Fetch news feed #71212

Merged
merged 6 commits into from
Jul 9, 2020
Merged

[Observability] Fetch news feed #71212

merged 6 commits into from
Jul 9, 2020

Conversation

cauemarcondes
Copy link
Contributor

closes #71052

Screenshot 2020-07-09 at 11 22 59

@cauemarcondes cauemarcondes requested a review from a team as a code owner July 9, 2020 09:24
@cauemarcondes cauemarcondes requested a review from sorenlouv July 9, 2020 09:24
sorenlouv
sorenlouv approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

ryankeairns
ryankeairns approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For design: just a folder rename.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
observability 44 +11 33

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 14752ea into elastic:master Jul 9, 2020
@cauemarcondes cauemarcondes deleted the obs-fetch-newsfeed branch July 9, 2020 17:13
@cauemarcondes cauemarcondes mentioned this pull request Jul 9, 2020
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Jul 9, 2020
@cauemarcondes @elasticmachine
[Observability] Fetch news feed (elastic#71212)
e57bd50 
* adding new feed

* adding log when an error happens

* fixing translations

Co-authored-by: Elastic Machine <[email protected]>
cauemarcondes added a commit that referenced this pull request Jul 9, 2020
@cauemarcondes @elasticmachine
[Observability] Fetch news feed (#71212) (#71280)
c1fd354 
* adding new feed

* adding log when an error happens

* fixing translations

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees
No one assigned
Labels
Feature:Observability Landing - Milestone 1 release_note:skip Skip the PR/issue when compiling release notes v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Observability] Fetch news feed
5 participants
@cauemarcondes @kibanamachine @sorenlouv @ryankeairns @elasticmachine