[ML] DF Analytics functional tests: re-enable regression, classification, and outlier creation #71006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
:ml
Feature:Data Frame Analytics
|
Pinging @elastic/ml-ui (:ml) |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
This was referenced Jul 8, 2020
walterra
approved these changes
Jul 8, 2020
| @@ -96,9 +96,9 @@ export default function ({ getService }: FtrProviderContext) { | |||
| await ml.dataFrameAnalyticsCreation.continueToAdditionalOptionsStep(); | |||
| }); | |||
|
|
|||
| it('inputs the model memory limit', async () => { | |||
| it('accepts the suggested model memory limit', async () => { | |||
There was a problem hiding this comment.
Nit: should we use "should" like it('should accept the suggested model memory limit', ...?
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jul 8, 2020
…ion, and outlier creation (elastic#71006) * update mml test. re-enable reg, class, and outlier creation tests * remove unnecessary second argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the analytics functional tests by checking that the model memory limit is populated from the results of the explain API instead of inputting it directly. I ran this branch through the flaky test suite and got no failures with these changes.
Related issues:
#70455 (classification/regression)
#70906 (outlier detection)
Checklist
Delete any items that are not applicable to this PR.