Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Functional test] Add retry for dashboard save #70950

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

majagrubic
Copy link
Contributor

Summary

Mitigation for #68845 - adding retry on dashboard save.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@majagrubic majagrubic added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 labels Jul 7, 2020
@majagrubic majagrubic requested review from a team and ThomThomson July 7, 2020 12:45
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM!

Ran through the problematic functional tests, and everything seems to work as expected.

@majagrubic majagrubic merged commit acd5da8 into elastic:master Jul 8, 2020
majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Jul 8, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 9, 2020
* master:
  [RUM Dashboard] New rum services api to replace usage of get services API (elastic#70746)
  fix: remove only consecutive ticks in TSVB (elastic#70981)
  [Functional test] Increase the timeout on opening a saved visualization (elastic#70952)
  [ML] Transforms/DFA: Refactor list action buttons so modals won't unmount after button click. (elastic#70555)
  [Functional test] Add retry for dashboard save (elastic#70950)
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 10, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Jul 13, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Functional Testing release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants