Fix kbn/optimizer tests #70827
Merged
Fix kbn/optimizer tests #70827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Jul 6, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jul 6, 2020
Co-authored-by: spalger <[email protected]> # Conflicts: # packages/kbn-optimizer/src/integration_tests/__snapshots__/basic_optimization.test.ts.snap
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jul 6, 2020
Co-authored-by: spalger <[email protected]> # Conflicts: # packages/kbn-optimizer/src/integration_tests/__snapshots__/basic_optimization.test.ts.snap
spalger
added a commit
that referenced
this pull request
Jul 6, 2020
Co-authored-by: spalger <[email protected]>
spalger
pushed a commit
that referenced
this pull request
Jul 6, 2020
Co-authored-by: spalger <[email protected]> # Conflicts: # packages/kbn-optimizer/src/integration_tests/__snapshots__/basic_optimization.test.ts.snap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70753
Fixes #70762
Fixes #70764
The
@kbn/optimizercaptures stdio from workers and makes it available on it's main event stream. The workers started randomly complaining:This was triggering new events in the stream and caused assertions to fail. To prevent that from being an issue now and in the future I'm filtering out
worker stdioevents from the stream.