[Ingest Manager] Fix agent version check to work with SNAPSHOT versions #70796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
bug
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jfsiii
approved these changes
Jul 6, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Jul 6, 2020
nchaulet
added a commit
that referenced
this pull request
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug introduced here #70339
Resolved #70726
During enrollment we check that the kibana version is >= to the agent version, this was not working with prerelease tag.
This PR fix that and add the tests to ensure it's working as expected.
the semver module has an option
includePrerelease: true|falsebut this seems to doesn't work as expected, so I just removed the prelease tag manually.