Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Fix detail page down monitor location badge text color #70778

Merged
merged 3 commits into from
Jul 6, 2020

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jul 6, 2020

Summary

Fixes #70777

Using white color for down badge danger color resolved the problem of invisible text.

After:

image

Before:
image

@shahzad31 shahzad31 requested a review from a team as a code owner July 6, 2020 09:58
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 labels Jul 6, 2020
@shahzad31 shahzad31 self-assigned this Jul 6, 2020
@shahzad31 shahzad31 requested a review from justinkambic July 6, 2020 10:00
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced on master and verified this patch fixes the issue.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime] Details page down location badge text is invisible
4 participants