-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KP] Separate onPreAuth & onPreRouting http interceptors #70775
Conversation
Pinging @elastic/kibana-platform (Team:Platform) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ACK: will review later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces changes LGTM, tested locally - seems to work as expected.
Co-authored-by: Aleh Zasypkin <[email protected]>
Co-authored-by: Aleh Zasypkin <[email protected]> Co-authored-by: Josh Dover <[email protected]>
This PR was merged, so this is largely a moot point; however, we should only merge code to master which we are confident works as expected. Bugs are sometimes discovered after a PR has merged, but this should be the exception, not the norm. |
… (#71523) Co-authored-by: Aleh Zasypkin <[email protected]> Co-authored-by: Josh Dover <[email protected]> Co-authored-by: Mikhail Shustov <[email protected]>
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/context/_date_nanos·js.context app context view for date_nanos displays predessors - anchor - successors in right orderStandard Out
Stack Trace
Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/context/_date_nanos·js.context app context view for date_nanos displays predessors - anchor - successors in right orderStandard Out
Stack Trace
Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_filter_bar·js.dashboard app using current data dashboard filter bar filter editor field list works when a vis with no index pattern is addedStandard Out
Stack Trace
and 3 more failures, only showing the first 3. Build metrics
History
To update your PR or re-run it, just comment with: |
Summary
Renames
onPreAuth
interceptor toonPreRouting
since it's used to support Spaces use-case to redirect an incoming request to space-aware URL before auth.Adds
onPreAuth
interceptor to support #70495 Fleet circuit breaker use-case when some logic should be performed after a route lookup, but before auth to avoid potentially expensive requests to ES server.Checklist
Delete any items that are not applicable to this PR.
For maintainers
Dev Docs
onPreAuth
interceptor has been renamed toonPreRouting
which reflects its place in the execution order better: it's called right before route lookup step. We added a newonPreAuth
interceptor executed before theAuth
lifecycle step, but afteronPreRouting
step.