-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics UI] Set includeTimeseries on Observability fetchData request #70735
[Metrics UI] Set includeTimeseries on Observability fetchData request #70735
Conversation
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simianhacker do we have our Snapshot API roughly documented anywhere? What does "includeTimeseries" do here?
Not really but I can create some if you would like. includeTimeseies adds the time series used to determine avg, value (last), and max to the metric object for the node. By default we return the last 5 buckets (which you can override with timeRange.lookback). If you send timeRange.ignoreLookback, then it will return all the buckets from the date histogram (for the time range). If you set forceInterval then it will use the interval in the timeRange object, otherwise it tries to use the interval from dataset.period of a sample document or falls back to 1 minute. Each setting was added for a specific use case. |
…elastic#70735) Co-authored-by: Elastic Machine <[email protected]>
…#70735) (#70986) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Summary
This PR closes #70695 by fixing the Metrics UI
fetchData
function so that it sets theincludeTimeseries
flag for the Snapshot API request.Checklist
Delete any items that are not applicable to this PR.