Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Set includeTimeseries on Observability fetchData request #70735

Merged

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Jul 3, 2020

Summary

This PR closes #70695 by fixing the Metrics UI fetchData function so that it sets the includeTimeseries flag for the Snapshot API request.

Checklist

Delete any items that are not applicable to this PR.

@simianhacker simianhacker added Feature:Metrics UI Metrics UI feature Feature:Observability Landing - Milestone 1 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0 labels Jul 3, 2020
@simianhacker simianhacker marked this pull request as ready for review July 3, 2020 17:59
@simianhacker simianhacker requested a review from a team as a code owner July 3, 2020 17:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@simianhacker simianhacker added the release_note:skip Skip the PR/issue when compiling release notes label Jul 3, 2020
@simianhacker
Copy link
Member Author

@elasticmachine merge upstream

@simianhacker simianhacker self-assigned this Jul 6, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simianhacker do we have our Snapshot API roughly documented anywhere? What does "includeTimeseries" do here?

@simianhacker
Copy link
Member Author

Not really but I can create some if you would like.

includeTimeseies adds the time series used to determine avg, value (last), and max to the metric object for the node. By default we return the last 5 buckets (which you can override with timeRange.lookback). If you send timeRange.ignoreLookback, then it will return all the buckets from the date histogram (for the time range). If you set forceInterval then it will use the interval in the timeRange object, otherwise it tries to use the interval from dataset.period of a sample document or falls back to 1 minute.

Each setting was added for a specific use case.

@simianhacker simianhacker merged commit f946e8e into elastic:master Jul 7, 2020
simianhacker added a commit to simianhacker/kibana that referenced this pull request Jul 7, 2020
simianhacker added a commit that referenced this pull request Jul 7, 2020
@simianhacker simianhacker deleted the issue-70695-fix-metrics-ui-obs-fn branch April 17, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature Feature:Observability Landing - Milestone 1 release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics] Observability overview page error while fetching data
4 participants