Fix extraneous bounds #7068
Merged
Fix extraneous bounds #7068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panda01
added
bug
| @@ -232,17 +232,25 @@ export default function MapFactory(Private) { | |||
| // TODO: Different drawTypes need differ info. Need a switch on the object creation | |||
| let bounds = e.layer.getBounds(); | |||
|
|
|||
| let SElng = bounds.getSouthEast().lng; | |||
| if (SElng > 180 ) { | |||
There was a problem hiding this comment.
Remove the space to make linter happy.
panda01
force-pushed
the
fix/extraneous-bounds
branch
2 times, most recently
from
ea59130 to
822ce39
Compare
|
LGTM |
|
I tried to find a way to make this prettier, not very much a fan of the code. But my search has been fruitless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply wrote code to check and make sure the bounds are in a particular range, and adjust them if not.
Closes #6794.