SECURITY-ENDPOINT: add fields for events to metadata document #70491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnamdifrankie
added
release_note:skip
kevinlog
approved these changes
Jul 1, 2020
| @@ -399,6 +399,13 @@ export type HostMetadata = Immutable<{ | |||
| '@timestamp': number; | |||
| event: { | |||
| created: number; | |||
| kind: string; | |||
| id: string; | |||
| category: string; | |||
There was a problem hiding this comment.
category and type can be an array per the ecs spec. I believe the endpoint will actually send these values as an array of a single value for metadata.
| @@ -363,6 +363,13 @@ export class EndpointDocGenerator { | |||
| '@timestamp': ts, | |||
| event: { | |||
| created: ts, | |||
| id: this.seededUUIDv4(), | |||
| kind: 'metric', | |||
| category: 'host', | |||
There was a problem hiding this comment.
category and type can be an array per the ecs spec. I believe the endpoint will actually send these values as an array of a single value for metadata.
My suggestion would be to mimic that and do category: ['host'] type: ['info']
jonathan-buttner
approved these changes
Jul 1, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
nnamdifrankie
added a commit
to nnamdifrankie/kibana
that referenced
this pull request
Jul 2, 2020
…c#70491) SECURITY-ENDPOINT: EMT-492 add fields for events to metadata document
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 2, 2020
* master: (46 commits) [Visualize] Add missing advanced settings and custom label for pipeline aggs (elastic#69688) Use dynamic: false for config saved object mappings (elastic#70436) [Ingest Pipelines] Error messages (elastic#70167) [APM] Show transaction rate per minute on Observability Overview page (elastic#70336) Filter out error when calculating a label (elastic#69934) [Visualizations] Each visType returns its supported triggers (elastic#70177) [Telemetry] Report data shippers (elastic#64935) Reduce SavedObjects mappings for Application Usage (elastic#70475) [Lens] fix dimension label performance issues (elastic#69978) Skip failing endgame tests (elastic#70548) [SIEM] Reenabling Cypress tests (elastic#70397) [SIEM][Security Solution][Endpoint] Endpoint Artifact Manifest Management + Artifact Download and Distribution (elastic#67707) [Security] Adds field mapping support to rule creation (elastic#70288) SECURITY-ENDPOINT: add fields for events to metadata document (elastic#70491) Fixed assertion in hybrid index pattern test to iterate through indices (elastic#70130) [SIEM][Exceptions] - Exception builder component (elastic#67013) [Ingest Manager] Rename data sources to package configs (elastic#70259) skip suites blocking es snapshot promomotion (elastic#70532) [Metrics UI] Fix asynchronicity and error handling in Snapshot API (elastic#70503) fix export response (elastic#70473) ...
nnamdifrankie
added a commit
that referenced
this pull request
Jul 2, 2020
#70547) SECURITY-ENDPOINT: EMT-492 add fields for events to metadata document
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue:
https://github.com/elastic/endpoint-app-team/issues/492
Checklist