Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] DF Analytics Regression Result: ensure MSE is accessed correctly #70438

Merged
merged 1 commit into from
Jul 1, 2020
Merged

[ML] DF Analytics Regression Result: ensure MSE is accessed correctly #70438

merged 1 commit into from
Jul 1, 2020

Conversation

alvarezmelissa87
Copy link
Contributor

Summary

This PR updates the way we access the return of _evaluate for regression jobs.
Since the changes introduced in elastic/elasticsearch#58726 - MSE value is now stored in value instead of error property.

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Data Frame Analytics ML data frame analytics features v7.9.0 labels Jul 1, 2020
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner July 1, 2020 13:27
@alvarezmelissa87 alvarezmelissa87 self-assigned this Jul 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87 alvarezmelissa87 requested review from darnautov and a team July 1, 2020 14:52
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@qn895
Copy link
Member

qn895 commented Jul 1, 2020

LGTM 👍

@alvarezmelissa87 alvarezmelissa87 merged commit edad017 into elastic:master Jul 1, 2020
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Jul 1, 2020
@alvarezmelissa87
update mse to access value property (elastic#70438)
4f2e925
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Jul 1, 2020
Merged
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfanalytics-mse-update branch July 1, 2020 18:42
darnautov pushed a commit that referenced this pull request Jul 2, 2020
@alvarezmelissa87
update mse to access value property (#70438) (#70496)
c16c37c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qn895 qn895 qn895 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alvarezmelissa87 @elasticmachine @kibanamachine @qn895 @peteharverson