Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Saved Object type mappings to set a field's doc_values property #70433

Merged
merged 6 commits into from
Jul 2, 2020

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Jul 1, 2020

Summary

This allows saved object type mappings to specify the doc_values property for fields. When fields aren't sorted or aggregated over doc_values: false won't add this field to the doc_values on-disk data structure which can reduce the overhead of specifying a field. https://www.elastic.co/guide/en/elasticsearch/reference/current/doc-values.html

Related to #43673

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@rudolf rudolf requested a review from a team as a code owner July 1, 2020 13:05
@rudolf rudolf added release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.9.0 v8.0.0 labels Jul 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@rudolf
Copy link
Contributor Author

rudolf commented Jul 2, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rudolf rudolf merged commit c686719 into elastic:master Jul 2, 2020
@rudolf rudolf deleted the so-mapping-doc-values branch July 2, 2020 13:50
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 2, 2020
* master:
  Update known-plugins.asciidoc (elastic#69370)
  [ML] Anomaly Explorer swim lane pagination (elastic#70063)
  [Ingest Manager] Update asset paths to use _ instead of - (elastic#70320)
  Fix discover, tsvb and Lens chart theming issues (elastic#69695)
  Allow Saved Object type mappings to set a field's `doc_values` property (elastic#70433)
  [S&R] Support data streams (elastic#68078)
  [Maps] Add styling and tooltip support to mapbox mvt vector tile sources (elastic#64488)
  redirect to default app if hash can not be forwarded (elastic#70417)
  [APM] Don't fetch dynamic index pattern in setupRequest (elastic#70308)
  [Security_Solution][Endpoint] Leveraging msearch and ancestry array for resolver (elastic#70134)
  Update docs for api authentication usage (elastic#66819)
  chore(NA): disable alerts_detection_rules cypress suites (elastic#70577)
  add getVisibleTypes API to SO type registry (elastic#70559)
rudolf added a commit to rudolf/kibana that referenced this pull request Jul 3, 2020
…ty (elastic#70433)

* Allow doc_values to be disabled

* Make doc_values optional

* doc_values type for CoreFieldMapping

* doc_values not doc_value

* Update docs

Co-authored-by: Elastic Machine <[email protected]>
rudolf added a commit that referenced this pull request Jul 3, 2020
…ty (#70433) (#70700)

* Allow doc_values to be disabled

* Make doc_values optional

* doc_values type for CoreFieldMapping

* doc_values not doc_value

* Update docs

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants