Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update links to Beats documentation #70380

Merged
merged 3 commits into from
Aug 21, 2020

Conversation

dedemorton
Copy link
Contributor

Summary

Starting in 7.9, the Beats getting started guides are refactored and reduced to a single page. This PR updates all Kibana links that point to the Beats getting started guides.

Replaces #70362

Follow-up to elastic/beats#19302.

@dedemorton dedemorton added review Team:Docs v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jun 30, 2020
@dedemorton dedemorton requested a review from a team as a code owner June 30, 2020 22:08
@dedemorton dedemorton requested a review from a team June 30, 2020 22:08
@dedemorton dedemorton self-assigned this Jun 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@gchaps
Copy link
Contributor

gchaps commented Jul 1, 2020

@elasticmachine merge upstream

@dedemorton
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links look correct to me

@bmorelli25
Copy link
Member

To fix your linting issues: https://www.elastic.co/guide/en/kibana/master/kibana-linting.html

@dedemorton
Copy link
Contributor Author

I know this has been sitting for awhile (just haven't gotten back to it). It's OK if this gets merged after 7.9 because the links won't actually break until I remove the redirects file that lives in the docs.

@dedemorton dedemorton force-pushed the update_gs_links_kibana branch from df04f28 to 0867520 Compare August 20, 2020 18:20
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
monitoring 1.1MB +106.0B 1.1MB

page load bundle size

id value diff baseline
core 1.2MB +18.0B 1.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dedemorton dedemorton merged commit 471b114 into elastic:master Aug 21, 2020
@dedemorton dedemorton deleted the update_gs_links_kibana branch August 21, 2020 16:08
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 21, 2020
* master: (71 commits)
  [Lens] Show 'No data for this field' for empty field in accordion (elastic#73772)
  Skip failing lens test
  Configure ScopedHistory consistenty regardless of URL used to mount app (elastic#75074)
  Fix returned payload by "search" usage collector (elastic#75340)
  [Security Solution] Fix missing key error (elastic#75576)
  Upgrade EUI to v27.4.1 (elastic#75240)
  Update datasets UI copy to data streams (elastic#75618)
  [Lens] Register saved object references (elastic#74523)
  [DOCS] Update links to Beats documentation (elastic#70380)
  [Enterprise Search] Convert our `public_url` route to `config_data` and collect initialAppData (elastic#75616)
  [Usage Collection Schemas] Remove Legacy entries (elastic#75652)
  [Dashboard First] Lens Originating App Breadcrumb (elastic#75470)
  Improve login UI error message. (elastic#75642)
  [Security Solution] modify circular deps checker to output images of circular deps graphs (elastic#75579)
  [Data Telemetry] Add index pattern to identify "meow" attacks (elastic#75163)
  Migrate CSP usage collector to `kibana_usage_collection` plugin (elastic#75536)
  [Console] Get ES Config from core (elastic#75406)
  [Uptime] Add delay in telemetry test (elastic#75162)
  [Lens] Use index pattern service instead saved object client (elastic#74654)
  Embeddable input (elastic#73033)
  ...
dedemorton added a commit that referenced this pull request Aug 21, 2020
* Update links to Beats documentation

* Update snapshot files

* Fix lint errors
dedemorton added a commit to dedemorton/kibana that referenced this pull request Sep 18, 2020
* Update links to Beats documentation

* Update snapshot files

* Fix lint errors
dedemorton added a commit that referenced this pull request Sep 18, 2020
* Update links to Beats documentation

* Update snapshot files

* Fix lint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Docs v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants