-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Added deprecated tag to the advanced settings for xPack:defaultAdminEmail #70280
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fb47f96
Added deprecated tag to the advanced settings
igoristic 28c5d45
Merge branch '7.x' of https://github.com/elastic/kibana into deprecat…
igoristic 50739f0
Addressed code feedback
igoristic 8dea103
Merge branch '7.x' of https://github.com/elastic/kibana into deprecat…
igoristic f0623bd
Code feedback
igoristic bdf11ac
Merge branch '7.x' of https://github.com/elastic/kibana into deprecat…
igoristic 84628e5
Merge branch '7.x' of https://github.com/elastic/kibana into deprecat…
igoristic 78cd7c4
Code feedback
igoristic 0bbc689
Fixed version
igoristic c59742b
Merge branch '7.x' into deprecate-default-email
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
import { CoreStart, CoreSetup } from 'kibana/server'; | ||
|
||
import { SavedObjectsClient } from '../../../../src/core/server'; | ||
|
||
export class CoreServices { | ||
private static _coreSetup: CoreSetup; | ||
private static _coreStart: CoreStart; | ||
|
||
public static init(core: CoreSetup) { | ||
this._coreSetup = core; | ||
} | ||
|
||
public static get coreSetup(): CoreSetup { | ||
this.checkError(); | ||
return this._coreSetup; | ||
} | ||
|
||
public static async getCoreStart(): Promise<CoreStart> { | ||
if (this._coreStart) { | ||
return this._coreStart; | ||
} | ||
const [coreStart] = await this.coreSetup.getStartServices(); | ||
this._coreStart = coreStart; | ||
return coreStart; | ||
} | ||
|
||
public static async getUISetting(key: string) { | ||
const coreStart = await this.getCoreStart(); | ||
const { savedObjects, uiSettings } = coreStart; | ||
const savedObjectsClient = new SavedObjectsClient(savedObjects.createInternalRepository()); | ||
const theSettings = uiSettings.asScopedToClient(savedObjectsClient); | ||
return await theSettings.get(key); | ||
} | ||
|
||
private static checkError() { | ||
if (!this._coreSetup) { | ||
throw new Error( | ||
'CoreServices has not been initialized. Please run CoreServices.init(...) before use' | ||
); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update this to
8.0
tooThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!