Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM][Timeline] Reset fields based on timeline #70209

Merged
merged 3 commits into from
Jun 30, 2020
Merged

[SIEM][Timeline] Reset fields based on timeline #70209

merged 3 commits into from
Jun 30, 2020

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Jun 29, 2020 •
edited
Loading

Summary

This PR fixes a bug when resetting the fields of a timeline. Specifically, when the user presses the reset fields button the fields are being reset to the defaults of each timeline based on its id.

Fixes: #70172

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jun 29, 2020
@cnasikas cnasikas requested review from a team as code owners June 29, 2020 14:49
@cnasikas cnasikas self-assigned this Jun 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

stephmilovic
stephmilovic approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Thank you for the tests. Code review ✅ manual testing ✅ LGTM 🏁

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 787 -5 792

History

  • 💔 Build #57596 failed 461dd7a20d568bc2b19aee9e7ea428be607c5d09
  • 💚 Build #57189 succeeded c2045a91d5534e76a4a23da17cdeef16ec4970f9
  • 💛 Build #57167 was flaky e8e43cf088d0f395607e2ce807fc1a4d97b26118

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas cnasikas merged commit aa52102 into elastic:master Jun 30, 2020
@cnasikas cnasikas deleted the timelines_defaults branch June 30, 2020 20:46
@cnasikas cnasikas mentioned this pull request Jun 30, 2020
Merged
cnasikas added a commit to cnasikas/kibana that referenced this pull request Jun 30, 2020
@cnasikas
[SIEM][Timeline] Reset fields based on timeline (elastic#70209)
27eeac7
cnasikas added a commit that referenced this pull request Jul 1, 2020
@cnasikas
[7.x] [SIEM][Timeline] Reset fields based on timeline (#70209) (#70368)
0ce23d5
@cnasikas cnasikas removed the v7.8.1 label Jul 1, 2020
Bamieh pushed a commit to Bamieh/kibana that referenced this pull request Jul 1, 2020
@cnasikas @Bamieh
[SIEM][Timeline] Reset fields based on timeline (elastic#70209)
e10c303
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

Assignees

@cnasikas cnasikas

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SIEM][Timeline] Wrong default fields when resetting for each timeline.
5 participants
@cnasikas @elasticmachine @kibanamachine @stephmilovic @MindyRS