Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed assertion in hybrid index pattern test to iterate through indices #70130

Merged
merged 6 commits into from
Jul 2, 2020
Merged

Fixed assertion in hybrid index pattern test to iterate through indices #70130

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1392989
Fixed assertion to check through all indices before making assertion.
Jun 26, 2020
4553bab
Restored yarn.lock file.
Jun 26, 2020
9bf5cb6
Removed only from describe.
Jun 26, 2020
ddc316f
Fixed linting issue.
Jun 27, 2020
c5fade8
Fixed nits that were in the PR conversation.
Jun 29, 2020
a983d35
Merge branch 'master' into Fixed_Assertion_In_Hybrid_Index_Pattern_Te…
elasticmachine Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions test/functional/page_objects/settings_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,13 @@ export function SettingsPageProvider({ getService, getPageObjects }: FtrProvider
);
}

async getAllIndexPatternNames() {
const indexPatterns = await this.getIndexPatternList();
return await mapAsync(indexPatterns, async (index) => {
cuff-links marked this conversation as resolved.
Show resolved Hide resolved
return await index.getVisibleText();
});
}

async isIndexPatternListEmpty() {
await testSubjects.existOrFail('indexPatternTable', { timeout: 5000 });
const indexPatternList = await this.getIndexPatternList();
Expand Down
9 changes: 5 additions & 4 deletions x-pack/test/functional/apps/rollup_job/hybrid_index_pattern.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,11 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.settings.createIndexPattern(rollupIndexPatternName, '@timestamp', false);

await PageObjects.settings.clickKibanaIndexPatterns();
const indexPattern = (await PageObjects.settings.getIndexPatternList()).pop();
const indexPatternText = await indexPattern.getVisibleText();
expect(indexPatternText).to.contain(rollupIndexPatternName);
expect(indexPatternText).to.contain('Rollup');
const indexPatternNames = await PageObjects.settings.getAllIndexPatternNames();
const filteredIndex = indexPatternNames.filter(
cuff-links marked this conversation as resolved.
Show resolved Hide resolved
(i) => i.includes(rollupIndexPatternName) && i.includes('Rollup')
cuff-links marked this conversation as resolved.
Show resolved Hide resolved
);
expect(filteredIndex.length).to.be(1);
});

after(async () => {
Expand Down